Memoization in Rails controllers

Question

I'm working with Rails 4.0 and I want to eliminate some duplicate lines but I don't know the implications doing this in Rails. As I understand an instance of a controller is created in every request ¹.

class ResetController < ApplicationController
  def reset_password
    user = User.find_by_email(params[:email])
    if user
      ...
  end

  def reset_user_token
    user = User.find_by_email(params[:email])
    if user
      ...
  end
end

If I'm not using Rails, my idea is extract a private method using memoization and remove the duplicated lines:

private

def user
  @user ||= User.find_by_email(params[:email])
end

Is it a good idea do this in Rails controller? How do you improve this code? I have a similar problem in a lot of parts of the application.

Related:
- When to use memoization in Ruby on Rails
- Rails Best Practices: Use memoization

its perfectly fine in this context

apneadiving
– apneadiving

2014-02-11 12:09:04 +00:00
Commented Feb 11, 2014 at 12:09 — apneadiving
– apneadiving, Commented Feb 11, 2014 at 12:09

thorsten müller · Accepted Answer · 2014-02-11 12:15:21Z

4

This seems not to have much to do with memoization, since as you say yourself, a new instance is started between those requests, so nothing would be 'stored'.

Still removing those duplicates in your code is a good idea. The Rails way to do this in your case would be a before_filter:

class ResetController < ApplicationController
  before_filter :find_user

  protected
  def find_user
    @user = User.find_by_email(params[:email])
    # here you could add some exception handling and prevent execution of action if no user is found (assuming you want to do this)
  end

answered Feb 11, 2014 at 12:15

thorsten müller

5,6591 gold badge24 silver badges30 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Memoization in Rails controllers

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related