Convert 2D float array into 1D array of strings

Question

I have a 2D array of floats and I want to convert it into 1D array of strings, where each string is one row of elements from 2D array. I am not getting output in text file as I expected. Can anyone tell me what I'm doing wrong? It will be great help to me, if somebody could provide efficient code with corrections.

string[] set = new string[240];

string value = "@"

for (int i = 0; i < 240; i++)
{
    for (int j = 0; j < 320; j++)
    {
        value = Convert.ToString(ImageArray[i, j]);
        value += ",";
    }

    set[i] = value + Environment.NewLine;
    value = " ";
}

for(int k=0;k<240;k++)
{
    System.IO.File.AppendAllText(@"C:\Users\mtech\Desktop\sathya.txt", set[k]);
    textBlock1.Text = set[k];
    value = " ";
}

Manish Mishra · Accepted Answer · 2014-02-14 04:24:51Z

4

inside your inner for loop(j), you are overwriting the value of value variable.

i.e.

for (int j = 0; j < 320; j++)
    {
        value = Convert.ToString(ImageArray[i, j]);
        value += ",";
    }

instead of above, you should be doing:

for (int j = 0; j < 320; j++)
    {
        value += Convert.ToString(ImageArray[i, j]) +",";
    }

also, you don't need to perform two nested loops for this task, take a look at String.Join

answered Feb 14, 2014 at 4:24

Manish Mishra

12.4k5 gold badges40 silver badges65 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user3068954 Over a year ago

yeah !! i realized the mistake after i posted the code, thanks a lot

Selman Genç · Accepted Answer · 2014-02-14 05:03:54Z

2

Here is the shorter way with LINQ:

var allValues = ImageArray.OfType<float>();
string[] lines = new string[240];
for(int i=0; i<240; i++)
{
   lines[i] = string.Join(",", allValues.Skip(i*320).Take(320));
}

 File.AppendAllLines(@"C:\Users\mtech\Desktop\sathya.txt", lines);

answered Feb 14, 2014 at 5:03

Selman Genç

102k15 gold badges126 silver badges193 bronze badges

Comments

pcnThird · Accepted Answer · 2014-02-14 04:55:48Z

1

You're re-assigning value in every iteration in your nested for loop. Use the += operator, instead. Another thing you should consider is the use of StringBuilder if you're going to repeatedly append to a string. strings are immutable so you're actually creating a new string every time you append to it.

Not sure if this applies to your case (because of the boundaries in your for loops), but you can use LINQ to flatten a multidimensional array. Example:

float[,] arr = new float[2,2]
{
    {123.48F, 45.3F},
    {954.23F, 91.3F}
};

var str = string.Join("",
              arr.Cast<float>()
             .Select(x => Convert.ToString(x) + ","));

edited Feb 14, 2014 at 4:55

answered Feb 14, 2014 at 4:46

pcnThird

2,3722 gold badges20 silver badges33 bronze badges

Collectives™ on Stack Overflow

Convert 2D float array into 1D array of strings

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related