Why doesn't this algorithm yield the fibonacci sequence under 100? [closed]

Question

Closed. This question is not reproducible or was caused by typos. It is not currently accepting answers.

This question was caused by a typo or a problem that can no longer be reproduced. While similar questions may be on-topic here, this one was resolved in a way less likely to help future readers.

Closed 11 years ago.

Improve this question

a = 1; b = 2
fibonacci = []
while fibonacci.length < 100
    fibonacci.push(a)
    fibonacci.push(b)
    a = a + b; b = a + b
end

push fibonacci

The error message is "undefined method `push' for main:Obj"

You're trying to #push the array itself on the last line! :) --That's what it's complaining about -- the method is being invoked on the 'main' object... I'm guessing you mean puts — Joseph Weissman
– Joseph Weissman, Commented Feb 17, 2014 at 4:04
Thank you! Silly mistake, should have said "puts" @JosephWeissman — megashigger
– megashigger, Commented Feb 17, 2014 at 4:08

Community · Accepted Answer · 2017-05-23 12:03:40Z

1

You're trying to #push the array itself on the last line! :)

That's what it's complaining about. The push method is being invoked on the 'main' object, and push is not a Kernel method.

I'm guessing you mean puts. Otherwise it looks okay, if somewhat non-idiomatic. Naturally you can find lots of Ruby solutions for this problem on the site that might read a bit more clearly (see here for a recursive one.)

edited May 23, 2017 at 12:03

CommunityBot

11 silver badge

answered Feb 17, 2014 at 4:35

Joseph Weissman

5,7175 gold badges49 silver badges76 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

sonnyhe2002 · Accepted Answer · 2014-02-17 05:30:23Z

1

As others have said before the last line should be 'puts' Also your numbers are wrong.

a = 1; b = 1
fibonacci = []
while fibonacci.length < 100
  fibonacci << a
  fibonacci << b
  a += b
  b += a
end

puts fibonacci

But also the fib starts at 1 and the the second element is also 1. This make you sequence off, if you start at 1, 2

Fib = 1, 1, 2, 3, 5, 8, ...

edited Feb 17, 2014 at 5:30

answered Feb 17, 2014 at 5:18

sonnyhe2002

2,1294 gold badges20 silver badges32 bronze badges

2 Comments

To마SE Over a year ago

Some people consider that 0 and 1 (rather than 1 and 1) are the starting numbers, see for instance Sloane (this is just meant to be informative, I'm not trying to nitpick or anything else).

sonnyhe2002 Over a year ago

You are right, in systems, it is at 0, 1, 1, .. But in general, it's 1, 1, but never 1, 2

Collectives™ on Stack Overflow

Why doesn't this algorithm yield the fibonacci sequence under 100? [closed]

2 Answers 2

Comments

2 Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Linked

Related