Insert data into SQL Server from a C# / ASP.NET application

First of all, you won't need the line CCC.Dispose() because that's the point of the using block - the resource will be disposed after use.

The code looks pretty much OK, apart from this line:

CCC.Parameters.Add("@Area", SqlDbType.Char, 80).Value =  80;

If you are using a char type and giving it an integer value, an exception will occur. Since you are swallowing the exception you will not see this error at all hence why no data is inserted.

Change the code to be like below and see if that works:

CCC.Parameters.Add("@Area", SqlDbType.Char, 80).Value =  "80";

Unless your 'Area' field is actually an integer type in the database. In that case you should change the SqlDbType accordingly.

You are right that some code is not needed. But first:

• Never catch an exception and just do nothing about it.

I suppose that you plan to put some error reporting there later, but in the mean time don't leave it as big hole where error messages goes to die. Just rethrow the exception so that you can see what's happening:

throw;

The try...catch block is of course only needed if you actually are going to catch the exception in this method. An alternative is to just omit the try...catch and let the exception bubble up and let code at a higher level handle it. It all depends on where you have enough information so that you can do something useful when you handle the exception.

The code that you don't need is:

• As you set the connection when you create the SqlCommand object, you don't need to set it again.
• As you are using using for both objects, you don't need to dispose the command or close the connection. THe using block does that for you.

Also:

• Naming the query connection is just confusing. I renamed it query and used the connection name for the connection instead. (Using a better name for the command variable would also be advisable, but I left it as is in the code to leave it more like your original.)

Revised code:

using (SqlConnection connection = new SqlConnection("Asset managementConnectionString")) {
  String query = "INSERT INTO Damage (Area,Building,Conference,Apartment,Room,DescribeDamage) VALUES (@Area,@Building,@Conference,@Apartment,@Room,@DescribeDamage)";
  using (SqlCommand CCC = new SqlCommand(query, connection)) {
    try {
      connection.Open();
      CCC.CommandType = CommandType.Text;

      CCC.Parameters.Add("@Area", SqlDbType.Char, 80).Value =  80;
      CCC.Parameters.Add("@Building", SqlDbType.Char, 9).Value = ddlBuildingCCC.ToString();
      CCC.Parameters.Add("@Conference", SqlDbType.Char, 5).Value = txtConferenceCCC.ToString();
      CCC.Parameters.Add("@Apartment", SqlDbType.VarChar, 4).Value = txtApartmentCCC.ToString();
      CCC.Parameters.Add("@Room", SqlDbType.VarChar, 10).Value = txtRoomCCC.ToString();
      CCC.Parameters.Add("@DescribeDamage", SqlDbType.VarChar, 100).Value = txtDescribeCCC.ToString();
      CCC.ExecuteNonQuery();
    } catch (SqlException) {
      throw; // just rethrow for now
    }
  }
}

There may of couse still be error in the code, for example mismatching data types, but now you should get an error message about it.

Naming is one thing really important in coding. I was looking to your snippet and the first thing that got my eye is that your connection string, I would actually called it command.

var cnnString = ConfigurationManager.ConnectionStrings["ConnectionString"].ConnectionString;

var command = "INSERT INTO Damage (Area,Building,Conference,Apartment,Room,DescribeDamage) VALUES (@Area,@Building,@Conference,@Apartment,@Room,@DescribeDamage)";

using (SqlConnection cnn = new SqlConnection(cnnString))
{
    using (SqlCommand cmd = new SqlCommand(command, cnn))
    {
        cmd.Parameters.AddWithValue("@Area", "80"); // Hardcoded value? Should be an int btw.
        cmd.Parameters.AddWithValue("@Building", ddlBuildingCCC.ToString());
        cmd.Parameters.AddWithValue("@Conference", ddlBuildingCCC.ToString());
        // ... the other values

        cnn.Open();
        cmd.ExecuteNonQuery();
    }
}

You also just need to open the connection before executing the command.