Javascript loop issue

Question

Hey I have a problem with one loop: I need to put html into JavaScript because it is a meme. Here is the code which is working fine but using document.write. I don't want use document.write as it is not working on Firefox:

for (var m = 1; m < 5; m++) {   
  document.write("<li onClick=\"hello2()\"><a href=\"#\"><script>document.write(wynik)<\/script><\/a><\/li>");
}

I tried to use:

document.getElementById('menu').innerHTML = "<li onClick=\"hello2()\"><a href=\"#\"><Script>document.write(wynik)<\/script><\/a><\/li>");

But it is not working porperly. Wrong format and showing only once in the loop.

Any suggestions ?

Just out of curiosity, why are you having javascript write a script tag? — Anonymous
– Anonymous, Commented Feb 20, 2014 at 12:27
i'm not a true fan of manipulating HTML content to the DOM with .innerHTML. I prefer createElement(), appendChild(), removeChild() ... — KarelG
– KarelG, Commented Feb 20, 2014 at 12:29
why is this for "<Script>document.write(wynik)<\/script>"? you are already scripting then just concate variable "wynik" — Sohil Desai
– Sohil Desai, Commented Feb 20, 2014 at 12:30
you can removeTag your tag and .append what ever tag you want to be added — Fury
– Fury, Commented Feb 20, 2014 at 12:31

Ash · Accepted Answer · 2014-02-20 13:25:32Z

2

document.getElementById('menu').innerHTML += "<li onClick=\"hello2()\"><a href=\"#\">" + wynik + "<\/a><\/li>";

Use += and remove ) then it will get work..

edited Feb 20, 2014 at 13:25

answered Feb 20, 2014 at 12:27

Ash

1,42015 silver badges32 bronze badges

Sign up to request clarification or add additional context in comments.

13 Comments

user3324547 Over a year ago

That works.. But what about the second document.write which is inside this one ?? <Script>document.write(wynik)<\/script>

Grundy Over a year ago

@user3324547 just use wynik direct, like '...<a href=\"#\">'+wynik+'<\/a>...'

Ash Over a year ago

Why you use document.write there ,Just write your variable only...That is wynik

user3324547 Over a year ago

wynik is result of some acitions before. It is variable.

user3324547 Over a year ago

what do you mean in clear html ? like that <li onClick="hello2()"><a href="#"><Script>wynik</script></a></li>. Its not working

|

Collectives™ on Stack Overflow

Javascript loop issue

1 Answer 1

13 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

13 Comments

Your Answer

Sign up or log in

Post as a guest

Related