Randomize Array then retrieve in foreach loop

Question

I'm trying to output the values of an array randomly, so there is no order to the way they are displayed. It works, not as expected.

They still display in the same order they are listed in the array, so I must be missing something..

    $itemArray = array("item1.php", "item2.php", "item3.php");
        shuffle($itemArray); 

        foreach ($itemArray as $item) {
                    shuffle($itemArray); 

                    include($itemArray[0]);

                }

Should I be using rand_array instead?

Paolo Bergantino · Accepted Answer · 2014-02-20 21:15:30Z

2

Inside your foreach the variable $item contains the current item, so it would look like:

foreach($itemArray as $item) {
    include($item);
}

Not sure what the reasoning is for including files in a random order, though...

answered Feb 20, 2014 at 21:15

Paolo Bergantino

490k83 gold badges523 silver badges437 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ed Capetti · Accepted Answer · 2014-02-20 21:19:57Z

0

There is no need for shuffle it again inside your foreach.

$itemArray = array("item1.php", "item2.php", "item3.php");
shuffle($itemArray); 

foreach ($itemArray as $item) {
     include($item);
}

Read the documentation for the correct use of foreach: http://www.php.net/manual/en/control-structures.foreach.php

answered Feb 20, 2014 at 21:19

Ed Capetti

3392 silver badges10 bronze badges

Comments

Sammitch · Accepted Answer · 2014-02-20 21:20:48Z

0

Simply this will suffice:

$itemArray = array("item1.php", "item2.php", "item3.php");
shuffle($itemArray); 

foreach ($itemArray as $item) {
    include($item);
}

shuffle() randomizes the array in-place, calling it multiple times is unnecessary and can cause items to be repeated or omitted.
You are looping through the elements in $itemArray, but repeatedly including $itemArray[0] for each iteration rather than the current item.

answered Feb 20, 2014 at 21:20

Sammitch

32.5k7 gold badges58 silver badges92 bronze badges

Collectives™ on Stack Overflow

Randomize Array then retrieve in foreach loop

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related