C struct example, errors during compilation

Question

I am trying to get familiar with struct and pointers in C and I am running into a bunch of syntax errors like "missing ';' before type", "missing ')' before type" and "undeclared identifier: 'i'". Everything seems fine, I know i is declared and I don't seem to be missing any ; or ).

#include <stdlib.h>
#include <stdio.h>

#pragma warning(disable: 4996)
struct Room; 
struct House;

struct Room 
{
    float width;
    float length;
    float height;
    char *name;
};

struct House
{
    char *address;
    struct Room *rooms[10]; 
};

int main(int argc, char* argv[])
{

    struct House h;
    h.address = "10 Palace Road";  
    for(int i = 0; i < 10; i++) // 6 errors occur here
    {
        h.rooms[i] = NULL;
    }
    struct Room hall;
    hall.width = 10;
    hall.length = 12;
    hall.height = 9;
    hall.name = "Hall";

    h.rooms[0] = &hall;
    printHouse(h);
    system("PAUSE");
    return 0;

}

void printHouse(struct House house)
{

    printf(house.address);
    printf("\n\n\n");

    for (int i=0; i<10; i++)
    {
        if (house.rooms[i] != NULL)
        {
            struct Room r = *house.rooms[i];
            printf("Room # %d: %s", i+1, r.name);
        }
    }
}

declare i outside of for. in some C compilers it doesnt work inside the for — Coldsteel48
– Coldsteel48, Commented Feb 21, 2014 at 0:33
struct Room hall; is a local variable. It will be reused on each iteration of the loop. — wildplasser
– wildplasser, Commented Feb 21, 2014 at 0:53
I resolved the issue, for some reason my source file was a .c file. I changed it to .cpp and everything compiled. Thanks for the feedback everyone! P.S. I am using Visual Studio 2010 — user3290335
– user3290335, Commented Feb 21, 2014 at 2:10

tesseract · Accepted Answer · 2014-02-21 01:03:31Z

4

printf(house.address);

should be

printf("%s",house.address);

Also you must declare your function printhouse, since you have defined it after main.

#include <stdlib.h>
#include <stdio.h>
#pragma warning(disable: 4996)
struct Room; //you don't need this

**EDIT**
struct House
{
char *address;
struct Room *rooms[10];
};
void printHouse(struct House house);

Declare House first then the function.

edited Feb 21, 2014 at 1:03

answered Feb 21, 2014 at 0:35

tesseract

9011 gold badge7 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

dckuehn · Accepted Answer · 2014-02-21 06:49:09Z

3

int i;
for (i = 0; i < 10; i++){
    //...
}

In earlier versions of C, you cannot declare I inside a loop.

edited Feb 21, 2014 at 6:49

answered Feb 21, 2014 at 0:34

dckuehn

2,4953 gold badges29 silver badges37 bronze badges

2 Comments

This isn't my real name Over a year ago

Really? Perhaps you mean that in versions of the C language older than C99, declarations must be at the beginning of a block?

Keith Thompson Over a year ago

@ElchononEdelson: You're talking about two distinct C99 features: mixing declarations and statements within a block, and declarations in for loop headers.

rohan babtiwale · Accepted Answer · 2014-02-21 00:36:49Z

2

Some versions of C compilers do not allow 'i' to be declared in the loop. Try declaring 'i' separately at the beginning of 'main()'. That should work.

answered Feb 21, 2014 at 0:36

rohan babtiwale

315 bronze badges

1 Comment

Keith Thompson Over a year ago

@Will: The use of system("PAUSE"); suggests that the OP is likely to be using a Microsoft compiler. Microsoft does not support C99.

Collectives™ on Stack Overflow

C struct example, errors during compilation

3 Answers 3

Comments

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related