I want to send two php values to a javascript function. Apparently it doesn't do anything. Is my syntax correct?
<script>
function onmouseclick(nr, name){
alert(nr);
alert(name);
}
</script>
<?php
echo '<img onClick="javascript: onmouseclick('. $template->id .','. $template->name .');" "class="img" />';
?>
You should add quotes:
echo '<img onClick="javascript: onmouseclick("'. $template->id .'", "'. $template->name .'");"
Yes you need to use as
echo '<img onClick="javascript: onmouseclick(\''. $template->id .'\',\''. $template->id .'\');" class="img" />';
Need to add the param inside quotes ' ' but since you are doing echo '...' you need to use escape \ so that the quotes are treated as string.
just use without php tags
<img onClick="javascript:onmouseclick('<?php echo $template->id;?>','<?php echo $template->name;?>');" class="img" />
or with php tags
echo '<img onClick="javascript: onmouseclick("'. $template->id .'", "'. $template->name .'");"
echo for that. In fact, you should avoid echoing HTML as much as possible. It just makes your code harder to maintain in the long run. Here is an example with a while loop and without echoing the HTML: codepad.org/B6Y0eeJZ. If you are using a fairly recent version of PHP, you can even use <?= instead of <?php echo, which makes the code even more readable.you can use this for avoiding character escape
echo sprintf('<img onclick="%s" class="img"/>',sprintf("onmouseclick(%d,'%s');",$template->id,$template->id));
echo sprintf() is an "antipattern". There is absolutely no reason that anyone should ever write echo sprintf() in any code for any reason -- it should be printf() without echo every time. This answer should have one printf(), no echo and no sprintf() calls. If you are going to keep this answer here, please edit it to completely refactor the approach.