jQuery - Show variable, not text string

Question

I have a variable being set as the .html(); of a <div />

The variable is the name of another variable. I want it to display the contents of the other variable, however it simply displays the name of the other variable.

How can I force it to show the variable contents rather than just a literal text string?

var clothing = 'dogeshop cryptoshop doge_clothing fyrstikken the_molly_machine peace_and_love moolah_market shibe_swag undieguys urban_graff kravshop got_doge mean_elephant the_dogedoor_store';


setInterval( function() {
    var term = $("input").val();
    $("#results").html(term);
}, 100);

When the user types 'clothing' into $("input"); the contents of the 'clothing' variable should be displayed in the $("#results"); <div />. Instead it just says 'clothing'.

I don't think this is the right mechanism. Why not use an associative array instead of a variable? So you'd look up the string 'clothing' (obtained from $("input").val()) and retrieve 'dogeshop cryptoshop...'? — lurker
– lurker, Commented Feb 21, 2014 at 21:28

Skwal · Accepted Answer · 2014-02-21 21:38:27Z

1

Another way is to use object properties, like this

var obj = {};
obj.clothing = 'dogeshop cryptoshop doge_clothing fyrstikken the_molly_machine peace_and_love moolah_market shibe_swag undieguys urban_graff kravshop got_doge mean_elephant the_dogedoor_store';


setInterval( function() {
    var term = $("input").val();
    $("#results").html(obj[term]);
}, 100);

Here's the fiddle: http://jsfiddle.net/ZL7EQ/

answered Feb 21, 2014 at 21:38

Skwal

2,1562 gold badges21 silver badges30 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Community · Accepted Answer · 2017-05-23 10:26:11Z

1

The only way I know how to solve this is using eval:

$("#results").html(eval(term))

But you really shouldn't want to do that. :)

edited May 23, 2017 at 10:26

CommunityBot

11 silver badge

answered Feb 21, 2014 at 21:38

rla4

1,2461 gold badge13 silver badges25 bronze badges

2 Comments

Skwal Over a year ago

@rla4, @william44isme using eval() on a user input is a big security issue!!

rla4 Over a year ago

Just edited my answer and added a link explaining why not. Just keep in mind that it has many pitfalls and use it wisely

Evan Davis · Accepted Answer · 2014-02-21 21:40:35Z

1

Use a dictionary.

// store strings in an object so you can look them up by key
var dict = {
    clothing: 'dogeshop ...',
    anotherKey: '...'
};

// update the result when the input changes
$('input').on('change', function() {
    var result = dict[this.value]; // make sure the key exists

    if (result) {
        $('#results').val(result); // update the results
    }
});

answered Feb 21, 2014 at 21:40

Evan Davis

36.7k7 gold badges53 silver badges58 bronze badges

1 Comment

william44isme Over a year ago

Wow! This is fantastic, thanks for optimising the code by removing that interval too.

War10ck · Accepted Answer · 2014-02-21 21:35:07Z

0

I use to make this mistake myself when working with jQuery.

Try instead:

 $("#results").text(term);

Not sure what you have the interval for. You could just change the #results with a change event.

edited Feb 21, 2014 at 21:35

War10ck

12.5k7 gold badges46 silver badges56 bronze badges

answered Feb 21, 2014 at 21:31

alexmac

2392 silver badges9 bronze badges

4 Comments

alexmac Over a year ago

results.text not html :)

william44isme Over a year ago

Yeah I tried that but it still doesn't seem to work. jsFiddle

alexmac Over a year ago

See w3schools.com/jquery/jquery_dom_set.asp , it shows the why and how. I know it works for the code, I took it from my own work. Let me try what you have there. And Also your interval event , look to the next answer for the ON event

Evan Davis Over a year ago

@alexmac you are misinterpreting the problem. It's not about setting the contents of the div; the issue is that the string clothing is being printed instead of the contents of the variable clothing.

Collectives™ on Stack Overflow

jQuery - Show variable, not text string

4 Answers 4

Comments

2 Comments

1 Comment

4 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

2 Comments

1 Comment

4 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related