for loop getting skipped in javascript

Question

I am trying to make a simple JavaScript guessing game, and my for loop keeps getting skipped! Here is the part of my code that is getting skipped:

for (i = 0; i === tries; i += 1) {
    isSkipped = false;
    var guessedNumber = prompt("Guess your number now.");

    console.log("User guessed number " + guessedNumber);

    //check if number is correct
    if (guessedNumber === numberToGuess) {
        confirm("Hooray, you have guessed the number!");
        break;
    } else if (guessedNumber > numberToGuess) {
        confirm("A little too high...");
    } else {
        confirm("A little too low...");
    }
}

and here is the full code:

//declaring variables
var numberToGuess;
var tries;
var i;
var isSkipped = true;

var confirmPlay = confirm("Are you ready to play lobuo's guessing game? The number for you to guess will be a number ranging from 1 to 25."); //does the user want to play?

if (confirmPlay === true) {
    console.log("User wants to play");
} else {
    window.location = "http://lobuo.github.io/pages/experiments.html";
} //if user wants to play, let them play, else go to website homepage

numberToGuess = Math.floor((Math.random() * 25) + 1); //sets computer-generated number

tries = prompt("How many tries would you like?"); //gets amount of tries
tries = Math.floor(tries); //converts amount of tries to integer from string

for (i = 0; i === tries; i += 1) {
    isSkipped = false;
    var guessedNumber = prompt("Guess your number now.");

    console.log("User guessed number " + guessedNumber);

    //check if number is correct
    if (guessedNumber === numberToGuess) {
        confirm("Hooray, you have guessed the number!");
        break;
    } else if (guessedNumber > numberToGuess) {
        confirm("A little too high...");
    } else {
        confirm("A little too low...");
    }
}

if (isSkipped === true) {
    console.log("Oh no! The for loop has been skipped!");
}

If you need any further details, just ask.

oops... I fixed that, but still nothing... It was supposed to be i += 1 — lobuo
– lobuo, Commented Feb 23, 2014 at 6:54

juvian · Accepted Answer · 2014-02-23 07:07:59Z

2

Shouldn't the for be like this?:

for (i = 0; i < tries; i += 1) {

edited Feb 23, 2014 at 7:07

answered Feb 23, 2014 at 6:55

juvian

16.1k2 gold badges42 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Qantas 94 Heavy Over a year ago

You might want to explain what's the difference between the two, and provide the edited code.

lobuo Over a year ago

oops... didnt notice you did i < tries. That fixed it. Thanks :D

Barmar · Accepted Answer · 2014-02-23 06:55:54Z

0

When you write:

for (i = 0; i === tries; i += 0) {

the loop repeats as long as the condition i === tries is true. If tries is 3, for instance, this condition is not true on the first iteration, and the loop ends immediately.

You should write:

for (i = 0; i < tries; i++) {

answered Feb 23, 2014 at 6:55

Barmar

789k57 gold badges554 silver badges669 bronze badges

Comments

Suman Bogati · Accepted Answer · 2014-02-23 07:08:06Z

0

Also you need to use parseInt() function on user's input.

 var guessedNumber = parseInt(prompt("Guess your number now."), 10);

instead of

var guessedNumber = prompt("Guess your number now.");

edited Feb 23, 2014 at 7:08

answered Feb 23, 2014 at 6:53

Suman Bogati

6,3612 gold badges25 silver badges38 bronze badges

5 Comments

Suman Bogati Over a year ago

why downvote as he checked for types also guessedNumber === numberToGuess?

Derek 朕會功夫 Over a year ago

@SumanBogati Because the type does not matter since it would be a Number no matter what after Math.floor.

Qantas 94 Heavy Over a year ago

@Derek朕會功夫: the OP doesn't do Math.floor on guessedNumber, but he does so on tries. Because guessedNumber is a string while numberToGuess is a number, it will never successfully complete.

Derek 朕會功夫 Over a year ago

@Qantas94Heavy - Oh I see it now. One more reason to use == it seems!

Suman Bogati Over a year ago

yeah how can be succeed 'string' === number.

Collectives™ on Stack Overflow

for loop getting skipped in javascript

3 Answers 3

2 Comments

Comments

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related