Checking session array for certain value

Question

function CHECKITEMEXIST($cartarray, $sub){
    foreach ($cartarray as $item){
        foreach ($item as $item2){
            if($item2['subject'] = $sub){
                return '1';

            }else{
                return '0';
            }
        }
    }
}

$subject = "English";
    $checkitemexist = CHECKITEMEXIST($cart, $subject);

if($checkitemexist > 0){
    echo "Yes";
}else{
    echo "No";
}

Guys I have the function below to check my cart array to see whether english subject exist or not, but the problem is even when english isn't in the cart array it will still return yes result, why is that so?

Below are the sample cart array.

Array ( [0] => Array ( [0] => Array ( [subject] => science ) ) )

You return '0' and '1', you should change that to 0 and 1. Stick with integers as much as you reasonably can (for performance). Also, on line4 on the 2nd piece of code you do >0. I suggest either !==0 or ===1. These are a tiny bit faster, but I personally because IMO it reads easier — Martijn
– Martijn, Commented Feb 25, 2014 at 10:07
Or even better, return true/false and do if( $checkitemexist ){ — Martijn
– Martijn, Commented Feb 25, 2014 at 10:08
I tried. The first value I pass in English, it will return yes, but the second value I pass in Science which is also in the cart array it returns no. I don't understand. — user3322610
– user3322610, Commented Feb 25, 2014 at 10:21

Satish Sharma · Accepted Answer · 2014-02-25 10:22:53Z

1

make it correct

if($item2['subject'] = $sub){   // = is an assignment operator

to

if($item2['subject'] == $sub){  // == is a comparison operator

UPDATE 2 :

try your modified function

function CHECKITEMEXIST($cartarray, $sub){
$flag = 0;
    foreach ($cartarray as $item){
        foreach ($item as $item2){
            if($item2['subject'] == $sub){
                $flag = 1;
            break;
            }
        }
        if($flag==1)
        {
            break;
        } 
    }
return $flag;   
}

edited Feb 25, 2014 at 10:22

answered Feb 25, 2014 at 10:03

Satish Sharma

9,6356 gold badges31 silver badges52 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user3322610 Over a year ago

I tried. The first value I pass in English, it will return yes, but the second value I pass in Science which is also in the cart array it returns no. I don't understand.

Collectives™ on Stack Overflow

Checking session array for certain value

1 Answer 1

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related