html and javascript form not working

Question

THis is the code :

<script>
    function searchFor(searchEngine,searchQuery){
        if (searchEngine="google"){
            var x="http://google.com.hk/search?q="+searchQuery;
            window.location=x
        }

        if (searchEngine="yahoo"){
            var x="http://hk.search.yahoo.com/search?p="+searchQuery;
            window.location=x
        }
     }
</script>

<form>
     <input type="radio" name="searchLoc" value="google"> Google <input type="radio" name="searchLoc" value="yahoo"> Yahoo
     <br>
     <input type="text" name="searchContent">
     <input type="submit" onclick="searchFor(this.form.searchLoc.value,this.form.searchContent.value);return false;" value="Search"
</form>

Why is it not working?

Once i click the submit button, nothing happened.

Pls help. Thx.

HB Kautil · Accepted Answer · 2014-02-28 09:01:06Z

2

You should write

<script>
function searchFor(searchEngine,searchQuery){
if (searchEngine=="google"){
var x="http://google.com.hk/search?q="+searchQuery;
window.location=x
}
if (searchEngine=="yahoo"){
var x="http://hk.search.yahoo.com/search?p="+searchQuery;
window.location=x
}
}
</script>

'==' instead of '=' in comparison

Change submit button also,

<input type="submit" onclick="searchFor(this.form.searchLoc.value,this.form.searchContent.value);return false;" value="Search" />

edited Feb 28, 2014 at 9:01

answered Feb 28, 2014 at 8:44

HB Kautil

2671 silver badge6 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

sanjeev · Accepted Answer · 2014-02-28 09:07:35Z

Certain error

a) it should be window.location.href

b) close the submit button tag

c) use '==' equal to for comparision

  <script>
    function searchFor(searchEngine,searchQuery){

     for (var i = 0; i < searchEngine.length; i++) {
        if (searchEngine[i].type === 'radio' && searchEngine[i].checked) {

            value = searchEngine[i].value;       
        }
    }


        if (value=="google"){
        var x="http://google.com.hk/search?q="+searchQuery;
        window.location.href=x
        }
        if (value=="yahoo"){
        var x="http://hk.search.yahoo.com/search?p="+searchQuery;
        window.location.href=x
        }
    }
    </script>

    <form>
    <input type="radio" name="searchLoc" value="google"> Google <input type="radio" name="searchLoc" value="yahoo"> Yahoo
    <br><input type="text" name="searchContent">
    <input type="submit" onclick="searchFor(this.form.searchLoc,this.form.searchContent.value);return false;" value="Search" />
</form>

lathako · Accepted Answer · 2014-02-28 08:52:45Z

<script type="text/javascript">
function searchFor(searchEngine,searchQuery){
    if (searchEngine=="google"){
        var x="http://google.com.hk/search?q="+searchQuery;
        window.location=x
    }
    if (searchEngine=="yahoo"){
        var x="http://hk.search.yahoo.com/search?p="+searchQuery;
        window.location=x;
    }
}
</script>

<form onsubmit="searchFor(this.form.searchLoc.value,this.form.searchContent.value);return false;">
<input type="radio" name="searchLoc" value="google"> Google <input type="radio" name="searchLoc" value="yahoo"> Yahoo
<br><input type="text" name="searchContent">
<input type="submit" value="Search"/>
</form>

Modify the code as above. searchEngine="google" should be searchEngine == "google" and use onsubmit on tag instead of onclick on submit button.

Pranav Singh · Accepted Answer · 2014-02-28 09:04:33Z

0

instead of:

  if (searchEngine="google")

try this:

if (searchEngine === "google")

edited Feb 28, 2014 at 9:04

Pranav Singh

20.3k32 gold badges83 silver badges109 bronze badges

answered Feb 28, 2014 at 8:46

user2575725

Collectives™ on Stack Overflow

html and javascript form not working

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related