Passing string as parameter onClick of dynamic button created in javascript

Question

i am creating a dynamic button in javascript and calling a function on its click,but I am not able to pass string parameter to it,what shoud be the proper code. I am doing this.

  document.getElementById(divfield).innerHTML +="<input type='button' value='-'class='remove_this"+i+"' onclick='  removed("+i+",'"+s+"')  '>";

here i is a integer,and s is a variable holding string.how should i pass string variable.

Could you create jsfiddle page for us?

AbstractProblemFactory
– AbstractProblemFactory

2014-02-28 11:34:04 +00:00
Commented Feb 28, 2014 at 11:34 — AbstractProblemFactory
– AbstractProblemFactory, Commented Feb 28, 2014 at 11:34
What did you actually get from this code?

Passerby
– Passerby

2014-02-28 11:35:16 +00:00
Commented Feb 28, 2014 at 11:35 — Passerby
– Passerby, Commented Feb 28, 2014 at 11:35
whatever m passing as string,it is giving as variable...

Abhi
– Abhi

2014-02-28 11:46:46 +00:00
Commented Feb 28, 2014 at 11:46 — Abhi
– Abhi, Commented Feb 28, 2014 at 11:46

Werner · Accepted Answer · 2014-02-28 11:41:38Z

2

I guess you want something like this:

var div = document.getElementById('divfield');

var input = document.createElement('input');
input.type = 'button';
input.value = '-';
input.setAttribute('class', 'remove_this' + i);
input.onclick = function () {
    removed(i,s)
}

div.appendChild(input);

jsfiddle: demo

answered Feb 28, 2014 at 11:41

Werner

2,1743 gold badges24 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Abhi Over a year ago

yes somewhat but,i want to pass a string onclick of the dynamic button

Abhi Over a year ago

Well thanks everyone, I m able to achieve this,so sharing the piece of code,may be anyone else can get help. document.getElementById(divfield).innerHTML +="<input type='button' value='-'class='remove_this"+i+"' onclick=' removed("+i+",\""+s+"\") '>";

Amir Sherafatian · Accepted Answer · 2014-02-28 12:00:04Z

0

you have missed some quotation mark on your code, if you try this:

innerHTML +="<input ..... onclick=' removed(" + i + ",\" " + s + "\ ") '>";

there will not any problem...

by your code, input element will be created like this: (notice to onclick attribute):

<input type="button" value="-" class="remove_this1" onclick="  removed(1," ss') '>

if: (i = 1) and (s = "ss") for example

edited Feb 28, 2014 at 12:00

answered Feb 28, 2014 at 11:53

Amir Sherafatian

2,0932 gold badges21 silver badges32 bronze badges

1 Comment

Abhi Over a year ago

thanks,this was the code,it worked for me,but I tried it by self before you posted.But thanks for answering.

Collectives™ on Stack Overflow

Passing string as parameter onClick of dynamic button created in javascript

2 Answers 2

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related