Trying to differentiate objects in array

Question

I'm having trouble differentiating objects in an array in one of my functions. I created an array that holds 8 enemies

enemy:Enemy;
enemyArray:Array = [];
for (i = 0; i < 8; i++)
{
    enemy = new Enemy();
    enemyArray.push(enemy);
}

Now each of these enemies are different because I assign them different strings. So for example,

enemyElemeny:String;
enemyArray[0].enemyElement = "Water";
enemyArray[1].enemyElement = "Fire";
etc....

Here's the problem. The player does more damage depending on the element of the enemy, however, it does the same damage to all enemies, possibly because I have enemyArray[j] in the if statement.

var j:int;
for (j = 0; j < enemyArray.length; j++)
{
    if (enemyArray[j] != null)
    {
        trace(enemyArray[0].enemyElement, enemyArray[1].enemyElement)
        if (player.playerElement == "Electric")
        {
           if (enemyArray[j].enemyElement == "Water") 
               { 
                     //DO A LOT OF DAMAGE
                     damage = 20
               }
           else if (enemyArray[j].enemyElement == "Fire") 
               {
                      //DONT DO A LOT OF DAMAGE
                      damage = 10 
               }
        }
    }
}

So if I have two enemies on the screen, one water and one fire, it'll do the same damage to both.

Vesper · Accepted Answer · 2014-03-02 06:01:23Z

1

You alter the only variable, named damage, and then you assign that damage to each of the enemies in turn, that's why you do the same damage to all the enemies. Instead, you should apply the damage to one enemy at a time within that loop of yours.

var j:int;
for (j = 0; j < enemyArray.length; j++)
{
if (enemyArray[j] != null)
{
    trace(enemyArray[0].enemyElement, enemyArray[1].enemyElement)
    if (player.playerElement == "Electric")
    {
       if (enemyArray[j].enemyElement == "Water") 
           { 
                 //DO A LOT OF DAMAGE
                 damage = 20
           }
       else if (enemyArray[j].enemyElement == "Fire") 
           {
                  //DONT DO A LOT OF DAMAGE
                  damage = 10 
           }
    }
    // put all the other elements of player&enemy in here
    enemyArray[j].takeDamage(damage); 
    // and then apply the calculated damage to only j'th enemy, not to every enemy
}
}

answered Mar 2, 2014 at 6:01

Vesper

18.8k6 gold badges41 silver badges63 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Bindlestick Over a year ago

Thanks for the reply. So when you say apply damage to one enemy at a time, would I need to replace the j with the actual numbers, like enemyArray[0], enemyArray[1], etc?

Vesper Over a year ago

No, your j already iterates through all the array. It's just when you apply damage, you alter only one object at a time, right after you calculate the damage it needs to receive.

Collectives™ on Stack Overflow

Trying to differentiate objects in array

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related