Array of Buttons in Java

Question

I tried to make an array of buttons:

Button[] buttonlist = new Button[2];

Button btn1;
Button btn2;
Button btn3;
btn1 = (Button) findViewById(R.id.button1);
btn2 = (Button) findViewById(R.id.button2);
btn3 = (Button) findViewById(R.id.button3);

buttonlist[0] = btn1;
buttonlist[1] = btn2;
buttonlist[2] = btn3;

What did I do wrong here ? Thanks !

The way you use it defeats the point of storing them into an array — Display Name
– Display Name, Commented Mar 2, 2014 at 12:33

Alexander · Accepted Answer · 2014-03-02 12:21:49Z

6

Must be Button[] buttonlist = new Button[3];

answered Mar 2, 2014 at 12:21

Alexander

48.4k40 gold badges110 silver badges163 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Lara Over a year ago

I thought counting of arrays starts at 0 ?

Alexander Over a year ago

Yes, but you have 3 buttons, not 2. When defining array you specify its size therefore 3. And having declared it you have button[0], [1] and [2]

Kiruba Karan · Accepted Answer · 2014-03-02 12:35:57Z

1

Array index in java doesnt start with 1...It starts with 0...This was the mistake you have done.. you must remove this line

buttonlist[2] = btn3;

or add this line

Button[] buttonlist = new Button[3];

answered Mar 2, 2014 at 12:35

Kiruba Karan

391 silver badge11 bronze badges

Comments

Harshal Benake · Accepted Answer · 2014-03-02 12:38:41Z

0

try this out.Hope it works :)

Button btn[] = new Button[2];
for (int i=0;i<2;i++){
    btn[i] = new Button(this); // initialize it
    btn[i].setLayoutParams(new LayoutParams(LayoutParams.MATCH_PARENT,LayoutParams.WRAP_CONTENT));
    btn[i].setText(name[i]);
    layout.addView(btn[i]);
}

edited Mar 2, 2014 at 12:38

answered Mar 2, 2014 at 12:31

Harshal Benake

2,4011 gold badge25 silver badges40 bronze badges

Comments

tanou · Accepted Answer · 2014-03-02 13:45:47Z

0

The answer above is fully right, but I just wanted to add that you could avoid using temporary variables and directly assign your button in your array:

Button[] buttonlist = new Button[3];

buttonlist[0] = (Button) findViewById(R.id.button1);
buttonlist[1] = (Button) findViewById(R.id.button2);
buttonlist[2] = (Button) findViewById(R.id.button3);

In my opinion, that's more readable ;)

answered Mar 2, 2014 at 13:45

tanou

1,0912 gold badges13 silver badges33 bronze badges

Collectives™ on Stack Overflow

Array of Buttons in Java

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related