CodeBlocks C++ Exception

Question

I'm having problem with this code:

#include<iostream>
#include<vector>
#include<algorithm>
#include<math.h>

using namespace std;

long long addV(int i) {
    return pow(10,i);
}

int len;

void recurse(int n,long long &ways,int values[],int current=0,int p=0) {
    if(p>len) return;
    if(current>n) return;
    if(current ==n) {
        ways++;
        return;
    }
    int cv = n-current;
    cv/=values[p];

    for(int i=0;i<=cv;i++) {
    recurse(n,ways,values,current+values[p]*i,p+1);
    }
}


int main() {
    int n;
    cin>>n;
    long long ways=0;
    int values[] ={1,2,3};
    len = sizeof(values)/sizeof(int);
    recurse(n,ways,values);
    cout<<ways;
}

The exception comes from (cv/=values[p];) line. Of course the shitty CodeBlocks never shows what the exception is. I'm sure its something easy to fix.

can you show me example of try/catch use ? I havent used it in C++ — user2919973
– user2919973, Commented Mar 2, 2014 at 14:05

timrau · Accepted Answer · 2014-03-02 14:04:59Z

1

if(p>len)return;

Indeed you've already accessed over boundary when p == len. You need to return once p >= len.

answered Mar 2, 2014 at 14:04

timrau

23.1k4 gold badges55 silver badges67 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Some programmer dude · Accepted Answer · 2014-03-02 14:05:11Z

1

Because among your ending condition for the recursion is p > len which means that p will be in the range from zero to three (inclusive). And as you know, an array of three entries have the indexes range from zero to two.

answered Mar 2, 2014 at 14:05

Some programmer dude

411k36 gold badges420 silver badges655 bronze badges

Collectives™ on Stack Overflow

CodeBlocks C++ Exception

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related