How to call a controller from within a view - Laravel

Question

I have a view that lists timesheets.

on that view, each timesheet has a deliverable field... I have a DeliverableController that has an action "DropdownList" that calls upon the model and gets a list of deliverables and pushes them to a deliverable view (which just creates a dropdown box).

When im looping through my timesheets I would like to get the response of the DeliverableController/DropdownList and put it where my deliverable field should be on the timesheet.

A) is there a way of getting the response of a controller from within a view
B) is there a way of getting the response of a controller from within a controller method, so that I can push the result to the view?

My code so far is:

DeliverableController:

class DeliverableController extends BaseController {   
    private $deliverableRepository;

    function __Construct( IDeliverableRepository $deliverableRepo )
    {
        $this->deliverableRepository = $deliverableRepo;
    }

    ...

    public /*  */ function DropdownList()
    {        
        $deliverables = $this->deliverableRepository->Deliverables(); 
        return View::make( 'Deliverable/_DropdownList', array( "Model" => $deliverables ) );
    }
}

Deliverables/_DropdownList View:

<?php
    foreach( $Model as $item )
    {
?>
    <select name="">
        <option value = "<?php echo $item->ID; ?>"><?php echo $item->Title; ?></option>
    </select>    
<?php
    }
?>

Timesheet Controller:

class TimesheetController extends BaseController {      
    private $timesheetRepository;

    function __Construct( ITimesheetRepository $timesheetRepo )
    {
        $this->timesheetRepository = $timesheetRepo;
    }

    ...

    // [HttpGET]
    public /*  */ function GetCreate()
    {       
        return View::make( 'Timesheet/Create' );
    }   

    // [HttpPOST]
    public /*  */ function PostCreate()
    { 
        // To do
    }    
}

Timesheet/Create

@extends( 'layout' )

@section( 'Styles' )
    <link href="<?php echo Request::root(); ?>/Styles/Timesheet.css" rel="stylesheet">
@stop

@section( 'Title' )
    Create timesheets
@stop

@section( 'Content' )

<form role="form">
    <table id="TimesheetTable" class="table">
        <thead>
            <tr>
                <th>Project/Deliverable</th>
                ...                
            </tr>
        </thead>
        <tfoot>
            <tr>
                <td></td>
                ...
            </tr>
        </tfoot>
        <tbody>
            <?php
                for( $a = 0; $a < 18; $a++ )
                {
            ?>
                    <tr id='row<?php echo $a; ?>'>
                        <td><?php /* Get response from DeliverableController/DropdownList */ ?></td>...                    
                    </tr>
            <?php
                }
            ?>
        </tbody>
    </table>
@stop

@section( 'Scripts' )
    <script src="<?php echo Request::root(); ?>/Scripts/Timesheet.js"></script>
@stop

Notice the /* Get response from DeliverableController/DropdownList */

Don't call a controller from within a view. The only way controllers should be accessed are via routes. Consider moving some of your logic out of the controller into a view composer or a model. — Collin James
– Collin James, Commented Mar 5, 2014 at 13:55

Badal · Accepted Answer · 2016-03-01 17:04:10Z

9

If you would like to call a controller from a view you can use the IOC container

    App::make(//ControllerName)->//methodName(//parameters);

Example:

    App::make("UserController")->displayUsers(array('page_id' => 55));

edited Mar 1, 2016 at 17:04

Badal

3,8174 gold badges39 silver badges60 bronze badges

answered Mar 3, 2014 at 17:31

Korush Mahdavieh

5411 gold badge5 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Jimmyt1988 Over a year ago

It even called the Factory for my dependancies... yoop yoop

Mr. Tomar Over a year ago

Hyy, I do like this <?php App::make("EmployerController")->create(); ?> but giving me error Class EmployerController does not exist

Korush Mahdavieh Over a year ago

@Tarzan Maybe worth checking if EmployerController is instantiate-able first

Antonio Carlos Ribeiro · Accepted Answer · 2014-03-03 16:50:46Z

1

This far from ideal, but a controller is a class as any other one, so you might be able to:

with(new UsersController)->doWhatever();

But if you are in need of doing something like that looks like your controllers are not really following some design patterns and they might have too much resposibilities, just to enlist some:

1 - A controller should not know much about your business logic. Controllers should receive a request send them to a model (or a repository) the the processed data and provide this data to a view or just redirect the user to another route.

2 - A controller should not be called by any other piece of code than the router itself.

3 - A view should not be aware of your classes and process things, they should receive data (already processed) from controllers and show them.

4 - The single responsibility principle that one should be responsible for doing just one. If your are calling a controller from your view, your view is being responsible for showing AND processing, and your controller is having the responsibility of a normal class (or a model or a repository) and also a controller.

And just with what you've said this list could go on...

What Laravel developers would basically tell you to do:

1 - Create a controller that does almost nothing:

class WhateverController extends Controller {

    private $repository;

    public function __construct(RepositoryInterface $repository)
    {
        $this->repository = $repository;
    }

    public function whatever()
    {
        $data = $this->repository->processData(Input::all());

        return View::make('your.view')->with(compact($data));
    }

}

2 - And everything that you need to do to generate data to your view you do in your repository class. You can have other classes instantiated (or inject) inside your repository to do whatever you need to do:

class Repository implements RepositoryInterface {

    public function processData($input)
    {
        $dataProcessor = new DataProcessor;

        return $dataProcessor->process($data);
    }

}

answered Mar 3, 2014 at 16:50

Antonio Carlos Ribeiro

87.9k22 gold badges220 silver badges205 bronze badges

3 Comments

Jimmyt1988 Over a year ago

Ill update with my code, because you've listed exactly what I've done (im a .net mvc developer so this is exactly what I do)

Jimmyt1988 Over a year ago

I've updated my OP... you can see it's what i'm doing but what I want is to make sure the controller gets its dependancies from the whole routing thing... just like in .Net MVC you have you controller and you can RenderAction( "Action", "Controller" ) and it goes and fulfils the job of the controller to get the models into the view and presents the view where you called it

Korush Mahdavieh Over a year ago

I totally agree about the design pattern, however instantiating an new UserController will not be included in the IOC container therefore using the App::make facade will be a better solution IMO

yussan · Accepted Answer · 2016-04-23 17:00:36Z

0

i think is better for you to create Class Aliases.

open app/config/app.php

add field on array aliases

example :

UserSession => App\Libraries\UserSession

and you can call it on your view simply

example :

UserSession::getData()

answered Apr 23, 2016 at 17:00

yussan

2,3472 gold badges22 silver badges25 bronze badges

Collectives™ on Stack Overflow

How to call a controller from within a view - Laravel

3 Answers 3

3 Comments

3 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related