The type 'System.Data.SqlClient.SqlDataReader' has no constructors defined

Question

I have issues with SqlDataReader. I get the error "The type 'System.Data.SqlClient.SqlDataReader' has no constructors defined" when I try running the page. My intention here is to return a string value 0 if the user has not had access or 1 when the user has assess. Below is my code snippet.

public string CheckAssess(string emailAddress, string columnName)
{
    string chkAssess;
    SqlDataReader readAssess;
    readAssess = new SqlDataReader();

    string MgrAssessQry = "SELECT '"+columnName+"' FROM tblAllUsers";
    MgrAssessQry += " WHERE email ='" + emailAddress + "'";

    SqlCommand cmdReadAssess = new SqlCommand(MgrAssessQry, cn);
    cn.Open();
    readAssess = cmdReadAssess.ExecuteReader();

    while(readAssess.Read())
    {
        // Add the rows
       chkAssess = readAssess["IsAssessMgr"].ToString();
    }

    return chkAssess;
}

Unrelated tips: SqlConnection, SqlCommand and SqlDataReader are all IDisposable so each should be in a using block. Also, beware constructing queries using string concatenation because it makes your code vulnerable to SQL injection attacks: use SQL parameters. — Richardissimo
– Richardissimo, Commented Jul 30, 2018 at 8:38

Vignesh Kumar A · Accepted Answer · 2014-03-04 10:41:40Z

3

Remove New from SqlDataReader Declaration.

Try this:

Change this

SqlDataReader readAssess;
    readAssess = new SqlDataReader();

to

SqlDataReader readAssess;

SqlDataReader

answered Mar 4, 2014 at 10:41

Vignesh Kumar A

28.6k14 gold badges67 silver badges119 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Abbas · Accepted Answer · 2014-03-04 10:39:18Z

2

The SqlDataReader class has no constructors, rewrite your code to following:

public string CheckAssess(string emailAddress, string columnName)
{
    string chkAssess;
    SqlDataReader readAssess;
    string MgrAssessQry = "SELECT '"+columnName+"' FROM tblAllUsers WHERE email ='" + emailAddress + "'";
    SqlCommand cmdReadAssess = new SqlCommand(MgrAssessQry, cn);

    cn.Open();
    readAssess = cmdReadAssess.ExecuteReader();

    while(readAssess.Read())
    {
        chkAssess = readAssess["IsAssessMgr"].ToString();
    }

    return chkAssess;
}

answered Mar 4, 2014 at 10:39

Abbas

14.5k6 gold badges43 silver badges77 bronze badges

Comments

Oscar Bralo · Accepted Answer · 2014-03-04 10:40:27Z

Try something like:

public string CheckAssess(string emailAddress, string columnName)
{
    string chkAssess;

    string MgrAssessQry = "SELECT '"+columnName+"' FROM tblAllUsers";
    MgrAssessQry += " WHERE email ='" + emailAddress + "'";

    SqlCommand cmdReadAssess = new SqlCommand(MgrAssessQry, cn);
    cn.Open();
    SqlDataReader readAssess = cmdReadAssess.ExecuteReader();

    while(readAssess.Read())
    {
        // Add the rows
       chkAssess = readAssess["IsAssessMgr"].ToString();
    }

    return chkAssess;
}

I have changed your SqlDataReader instantiation to the line where you execute the query Same way like in this example from MSDN

http://msdn.microsoft.com/es-es/library/system.data.sqlclient.sqldatareader(v=vs.110).aspx

Nagaraj S · Accepted Answer · 2014-03-04 11:07:26Z

1

Chang your

 readAssess = new SqlDataReader ();

 readAssess = cmdReadAssess.ExecuteReader();

to

 SqlDataReader readAssess= cmdReadAssess.ExecuteReader();

SqlDataReader Class

edited Mar 4, 2014 at 11:07

answered Mar 4, 2014 at 10:46

Nagaraj S

13.5k6 gold badges35 silver badges53 bronze badges

2 Comments

Panagiotis Kanavos Over a year ago

This won't compile because readAssess is already defined with the proper type. The exception doesn't even occur at this line

Nagaraj S Over a year ago

@PanagiotisKanavos thankyou i have updated .Please have a look

Mr.Wimol Prommajorm · Accepted Answer · 2016-01-07 04:01:13Z

I had the same problem. I resolved by a simple way like this.

SqlDataReader read = null;
and to check 'read' has row or not
if(read.HasRows)
{
   while(read.Read()){}
}


So please see this your code.

public string CheckAssess(string emailAddress, string columnName)
{
    string chkAssess;
    SqlDataReader readAssess;
    readAssess = null; // this from my comments

    string MgrAssessQry = "SELECT '"+columnName+"' FROM tblAllUsers";
    MgrAssessQry += " WHERE email ='" + emailAddress + "'";

    SqlCommand cmdReadAssess = new SqlCommand(MgrAssessQry, cn);
    cn.Open();
    readAssess = cmdReadAssess.ExecuteReader();

    if(readAssess.HasRows && readAssess != null) // this from my comments
    {
       while(readAssess.Read())
       {
          // Add the rows
          chkAssess = readAssess["IsAssessMgr"].ToString();
       }
     }

     return chkAssess;
 }

 // I hope this code would help you.

Collectives™ on Stack Overflow

The type 'System.Data.SqlClient.SqlDataReader' has no constructors defined

5 Answers 5

Comments

Comments

Comments

2 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related