Adding model object to list fails

Question

I have a model class like this

  namespace ConnectBLL.DTO.Response
{
    public class CategorySettings
    {
        public bool NeedsLoginToViewLongText { get; set; }
        public bool NeedsLoginToViewAnyDetails { get; set; }
        public bool ShowAttachment { get; set; }
        public string CategoryPageID { get; set; }
        public string TpUrl { get; set; }
    }

    public class CategorySettingsListResponse
    {
        public List<CategorySettings> CategorySettingsList { get; set; }
    }
}

And I am trying to add data to it like this

    private readonly CategorySettings cs = new CategorySettings();
 CategorySettingsListResponse csr=new CategorySettingsListResponse();
 public string GetAllCategorySettings()
    {


            cs.NeedsLoginToViewLongText = true;
            cs.NeedsLoginToViewAnyDetails = false;
            cs.ShowAttachment = true;
            cs.CategoryPageID = "1";
            cs.TpUrl = "url";
            csr.CategorySettingsList.Add(cs);

    }

But this fails and gives an error

Object reference not set to an instance of an object.

Can any one point out what is I am doing wrong?

Where is cs defined ?

Ofiris
– Ofiris

2014-03-04 13:16:11 +00:00
Commented Mar 4, 2014 at 13:16 — Ofiris
– Ofiris, Commented Mar 4, 2014 at 13:16
@Ofiris I missed it in the question. added now

None
– None

2014-03-04 13:20:05 +00:00
Commented Mar 4, 2014 at 13:20 — None
– None, Commented Mar 4, 2014 at 13:20

Steve · Accepted Answer · 2014-03-04 13:16:43Z

2

Somewhere, you need to initialize CategorySettingsList.

public class CategorySettingsListResponse
{
    CategorySettingsListResponse() {
        CategorySettingsList = new List<CategorySettings>();
    }

    public List<CategorySettings> CategorySettingsList { get; set; }
}

answered Mar 4, 2014 at 13:16

Steve

6,4644 gold badges47 silver badges74 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

user2488279 · Accepted Answer · 2014-03-04 13:17:41Z

2

You are tying to use an instance of List before initializing. Before

csr.CategorySettingsList.Add(cs);

Insert:

if (csr.CategorySettingsList == null) {
    csr.CategorySettingsList = new List<CategorySettings>();
}

answered Mar 4, 2014 at 13:17

user2488279

1 Comment

musefan Over a year ago

or just put it in the CategorySettingsListResponse constructor

alexmac · Accepted Answer · 2014-03-04 13:15:47Z

1

You are using uncreated objects cs and CategorySettingsList, you should create them before use:

public string GetAllCategorySettings()
{
    csr.CategorySettingsList = new ListCategorySettings<>();
    var cs = new CategorySettings
        {
           NeedsLoginToViewLongText = true,
           ...

answered Mar 4, 2014 at 13:15

alexmac

19.7k7 gold badges64 silver badges74 bronze badges

Comments

Henrik · Accepted Answer · 2014-03-04 13:16:53Z

1

What is cs? Something missing?

You forgot to do this:

 var cs = new CategorySettings();

Also

You need to instantiate the CategorySettingsList in constructor for CategorySettingsListResponse.

answered Mar 4, 2014 at 13:16

Henrik

1,8174 gold badges24 silver badges47 bronze badges

Collectives™ on Stack Overflow

Adding model object to list fails

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related