Using .insert with Ruby Arrays

Question

I have a function that is parsing an array of numbers into a string in correct phone number format. Is there any way to condense this so that I only have to call .insert once?

createPhoneNumber([1, 2, 3, 4, 5, 6, 7, 8, 9, 0]) returns "(123) 456-7890")

def createPhoneNumber(numbers)
  numbers.insert(6, "-")
  numbers.insert(0, "(")
  numbers.insert(4, ")")
  numbers.insert(5, " ")
  numbers.join
end

This is something that'll break if you have international users, as phone number lengths and formats vary around the world. Also, method names are not camelCase, they're snake_case in Ruby so use create_phone_number. — the Tin Man
– the Tin Man, Commented Mar 5, 2014 at 6:00

Matt · Accepted Answer · 2014-03-05 03:48:33Z

3

If you don't mind passing in a 10-character string instead, you can do

def createPhoneNumber( p )
    '(%s) %s-%s' % [p[0,3],p[3,3],p[6,4]]    
end

Example:

createPhoneNumber('1234567890') # => "(123) 456-7890"

answered Mar 5, 2014 at 3:48

Matt

20.8k1 gold badge61 silver badges76 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

the Tin Man Over a year ago

Using a string is the right way to start. We see them in the "(xxx) xxx-xxxx" format in the US often, but elsewhere they'll vary. Even assuming they're ten digits is dangerous so the OP is painting their app into a US-centric corner.

Amadan · Accepted Answer · 2014-03-05 03:48:12Z

2

def createPhoneNumber(numbers)
  "(#{numbers[0..2].join}) #{numbers[3..5].join}-#{numbers[6..9].join}"
end

There is no way I can think of where you would use insert, and use it only once.

answered Mar 5, 2014 at 3:48

Amadan

200k23 gold badges252 silver badges321 bronze badges

Collectives™ on Stack Overflow

Using .insert with Ruby Arrays

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related