Optional Rails Params in Controller Query

Question

I have a question in regards to Rails params. I currently have only one filter on one of my views that allows users to filter data by a date range. I am adding two more filters to that view so that users can filter by code and country. However, I want those filters to be optional.

My current query looks something like this:

@data = Games
      .where("date BETWEEN ? AND ?", *date_range_array)
      .includes(:synced_country)
      .order(sort_column + " " + sort_direction)
      .page(params[:page])

The params for code and country will be something like, params[:code] and params[:country]. I would like to put them in the query like:

  @data = Games
          .where("date BETWEEN ? AND ?", *date_range_array)
          .where("unique_code in ?" params[:code])
          .where("country in ?" params[:country])
          .includes(:synced_country)
          .order(sort_column + " " + sort_direction)
          .page(params[:page])

The issue I am having is that if the user does not input anything for params[:code] and params[:country] I get an error because they are nil. Any idea on how to handle this kind of situation?

Agis · Accepted Answer · 2014-03-06 15:13:01Z

1

I would build it incrementally:

@data = Games.where("date BETWEEN ? AND ?", *date_range_array)

@data = @data.where("unique_code in ?", params[:code]) if params[:code]
@data = @data.where("country in ?", params[:country])  if params[:country]

@data = @data.includes(:synced_country)
             .order(sort_column + " " + sort_direction)
             .page(params[:page])

Note that you are missing two commas right before params[:code] and params[:country] which I've fixed in the above code.

answered Mar 6, 2014 at 15:13

Agis

33.8k4 gold badges77 silver badges81 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

arieljuod · Accepted Answer · 2014-03-06 15:08:42Z

0

@data = Games.where("date BETWEEN ? AND ?", *date_range_array).scoped
@data = @data.where("unique_code in ?" params[:code]).scoped if params[:code].present?
@data = @data.where("country in ?" params[:country]).scoped if params[:coutry].present?
@data = @data.includes(:synced_country)
             .order(sort_column + " " + sort_direction)
             .page(params[:page])

Anyway, I would move that complex query to a named scope or something inside the Game Model.

EDIT: added the "scoped" method, i'm not sure if needed, try it without .scoped if you want

answered Mar 6, 2014 at 15:08

arieljuod

15.9k2 gold badges27 silver badges37 bronze badges

1 Comment

sevenseacat Over a year ago

or a query object - I like those!

peipei · Accepted Answer · 2014-03-06 15:52:48Z

0

I usually use the same method with Agis. But sometimes I trend to use scope(as arieljuod said):

class Games

  scope :in_contry, lambda{|contry| where("contry in ?", contry) if contry.present?}

  scope :in_code, lambda{|code| where("unique_code in ?", code) if code.present?}

  //other codes
end

//call lambdas as follows:
@data = Games.where("date BETWEEN ? AND ?", *date_range_array)
          .in_code(params[:code])
          .in_contry(params[:country])
          .includes(:synced_country)
          .order(sort_column + " " + sort_direction)
          .page(params[:page])

answered Mar 6, 2014 at 15:52

peipei

212 bronze badges

Collectives™ on Stack Overflow

Optional Rails Params in Controller Query

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related