Class variable vs passing parameter in java - design issue

Question

Say I have 2 classes in an SOA model application..

Service class - which takes request and returns response
For further processing (say, business logic/parsing/dao etc), it passes the request to a SvcBusiness class.

Question is, should SvcBusiness class use the request as its class variable or should it just use the request in one of it's business methods? It is possible that request needs to be passed to other lower layers like DAO layer. Should those classes also use request as a class variable or should the request be just part of a method?

ServiceImpl class:

public class ServiceImpl {

   public Response getDataForType1Request(Request type1) {
      SvcBusiness buzclazz = new SvcBusiness();
      return buzclazz.doOperationForType1(type1);
   }

   public Response getDataForType2Request(Request type2) {
      SvcBusiness buzclazz = new SvcBusiness();
      return buzclazz.doOperationForType2(type2);
   }

}

Option 1: when request is passed as a parameter.

public class SvcBusiness {

   public Response doOperationForType1(Request type1) {
      // do business and return response1
   }

   public Response doOperationForType2(Request type2) {
      // do business and return response2
   }

}

Option 2: request is set as a class variable. In this scenario.. ServiceImpl will pass the request to SvcBusiness constructor when the object is created.. and will simply call execute() method.

public class SvcBusiness {

   private Request request;

   public SvcBusiness(Request request) {
      this.request = request;
   }

   private Response doOperationForType1() {
      // do business and return response1
   }

   private Response doOperationForType2() {
      // do business and return response2
   }

   public Response execute() {
      // if type1 request call doOperationForType1()
      // if type2 request call doOperationForType1()
   }

}

Please help! What are the advantages and disadvantages of both? Is there a design pattern to address this scenario?

Uwe Allner · Accepted Answer · 2014-03-07 13:13:23Z

2

Don't use the Request (and Response) further down in your class hierarchy! The service (and everything called by the service) may be called from somewhere else, where there is no such thing as a Request. And then you will have a problem with filling that parameter. Use an own data model in the service, and extract and convert everything you need for that from the Request.

answered Mar 7, 2014 at 13:13

Uwe Allner

3,4879 gold badges40 silver badges52 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Andres · Accepted Answer · 2014-03-07 13:18:35Z

0

Fully agree with Uwe's answer. However, if you still want to use Request class, it'll be less harmful as a parameter (The way Servlets work). Otherwise, you'd have to deal with synchronization on a highly probable multithreaded environment.

answered Mar 7, 2014 at 13:18

Andres

10.7k4 gold badges50 silver badges65 bronze badges

Comments

Pablo Lozano · Accepted Answer · 2014-03-07 13:19:53Z

0

When I face a problem like this I always wonder if I really need an object. Usually I use the option 1 but creating all methods as static. As those methods don't rely in the current object state (there are no instance attributes), I save some memory just not creating such objects (other option is just implement the Singleton pattern).

public class SvcBusiness {

   public static Response doOperationForType1(Request type1) {
      // do business and return response1
   }

   public Response doOperationForType2(Request type2) {
      // do business and return response2
   }

}

answered Mar 7, 2014 at 13:19

Pablo Lozano

10.4k2 gold badges43 silver badges64 bronze badges

Collectives™ on Stack Overflow

Class variable vs passing parameter in java - design issue

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related