java - issue with exceptions

Question

I'm having some trouble getting my code to compile.

This is a method that uses the class Value to save text to a file

public void saveEventsToFile() throws Exception {
    String tmp = getEventsAsString();
    value = Value.makeString(tmp);
    Value.saveFile(value, "\\events" + "\\" + "YEAR" + "\\" + months[MONTH] + "\\" + DAY);
}

and this is part of a constructor of another object. I've got an actionlistener on a button (OK) and when that button is pressed, I want to call the saveEventsToFile method.

OK.addActionListener(new ActionListener() {
        public void actionPerformed(ActionEvent e) {
            int h, m;
            h = (Integer) hourSpinner.getValue();
            m = (Integer) minuteSpinner.getValue();
            parentPanel.createNewEvent(parentPanel.selectedBox, parentWindow,       textPane.getText(), h, m);
            parentPanel.selectedBox.saveEventsToFile();
            dispose();
        }
    });

If I add throws Exception on actionPerformed my code does not compile, and without it I get "Unhandled exception" error on the arentPanel.selectedBox.saveEventsToFile(); line

How could I get this to compile? I've not had much experience with exceptions.

in eclipse mouse-over the error line and click "surround with try-catch" option — donfuxx
– donfuxx, Commented Mar 9, 2014 at 17:54

Stefan · Accepted Answer · 2014-03-09 18:22:26Z

1

As donfuxx said:

OK.addActionListener(new ActionListener() {
        public void actionPerformed(ActionEvent e) {
            int h, m;
            h = (Integer) hourSpinner.getValue();
            m = (Integer) minuteSpinner.getValue();
            parentPanel.createNewEvent(parentPanel.selectedBox, parentWindow,       textPane.getText(), h, m);
            try {
                parentPanel.selectedBox.saveEventsToFile();
            } catch (ExeptionThaIsThrownBySaveEventsMethod e) {
                // display error
            }
            dispose();
        }
    });

edited Mar 9, 2014 at 18:22

answered Mar 9, 2014 at 17:56

Stefan

2712 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

dingari Over a year ago

Well, that did the trick. But one more question, when I don't specify a certain path the file is saved directly in the project folder. But when I specify a path within the project folder (e.g. "\\events" + "\\" + "YEAR" + "\\" + months[MONTH] + "\\" + DAY) I get a "file not found exception". How can I specify this path?

Stefan Over a year ago

Please mark answer as correct and open a new question for this problem.

dingari Over a year ago

nvm I figured it out :)

Damian Leszczyński - Vash · Accepted Answer · 2014-03-09 18:17:09Z

First of all if you do not use any particular element of ActionEvent, move logic of the method in the body of class you have.

OK.addActionListener(new ActionListener() {
        public void actionPerformed(ActionEvent e) {

                Integer h = (Integer) hourSpinner.getValue());
                Integer m = (Integer) minuteSpinner.getValue(); 

             saveEventsToFile(h,m)
              dispose();
        }
    });

private void saveEventsToFile(Integer hour, Integer minute) {

   if(hour == null || minute == null) {
     throw new IllegalArgumentException("The parameters must not be null.")
   }

   parentPanel.createNewEvent(parentPanel.selectedBox, parentWindow, textPane.getText(), h,m);

   try {
     parentPanel.selectedBox.saveEventsToFile();
   }catch(ExeptionThaIsThrownBySaveEventsMethod e) {
     throw new IllegalStateException(e);
   }
}

The things to remember here is that you should avoid to catch Exception as you may catch more than expected. This is important because after some exceptions application can proceed in other just need to be closed. In case the save cased an exception is might be possible that user can do something to retry the operation. In case the application must be close as can not longer operate you change use an unchecked (Runtime) Exception.

Collectives™ on Stack Overflow

java - issue with exceptions

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related