How to do Form Validation in Javascript

Question

I Write This code For Registration of a User. Now I want to Validate this Page Whether all the Fields are Filled by the user or Not. The Same Script Code I Write to Login page It's Showing an alert if any one filed empty in the page. But it is not working for this Page.

The Main Difference is i Used Div in Login Page here I Used Table.

Registration Page Code :

<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8"/>
<link rel="stylesheet" type="text/css" href="css/Registration.css">
<script>
function validateForm()
{
var a=document.forms["regform"]["user"].value;
var b=document.forms["regform"]["pass"].value;
var c=document.forms["regform"]["copa"].value;
var d=document.forms["regform"]["mono"].value;
if(a==""||b==""||c=""||d="")
{
    alert("Please Enter All the Fields");
    return false;
}
else
{
    window.location="afterregister.html"
    //alert("Registered Successfully");
}
 }
</script>
</head>
<body>
<h1>Registration</h1>
<form name="regform" onsubmit="return validateForm();" method="post">
<table>
<tr>
    <td><label>Username:</label></td>
    <td><input type="text" name="user"/></td>
</tr>
<tr>
    <td><label>Password:</label></td>
    <td><input type="text" name="pass"/></td>
</tr>
<tr>
    <td><label>Confirm Password:</label></td>
    <td><input type="text" name="copa"/></td>
</tr>
<tr>
    <td><label>Mobile Number:</label></td>
    <td><input type="text" name="mono"/></td>
</tr>
<tr>
<td></td>
    <td><input type="button" onclick = "return validateForm()" value="Register" name="" class="row1" />
    <input type="button" name="" value="Cancel" class="row1"></td>
</tr>
<tr>
<td></td>
    <td><input type="button" name="" value="Forgot Password" class="row2"></td>
</tr>
    </table>
</form>
</body>
</html>

Login Page Code:

<!DOCTYPE html>
<html lang="en">
<head>
<title></title>
<meta charset="utf-8"/>
<link rel="stylesheet" type="text/css" href="css/Login.css">
<script>
function myFunction()
{
var x=document.forms["loginform"]["user"].value;
var y=document.forms["loginform"]["pass"].value;
if(x==""||y=="")
{
    alert("Please Enter All the Fields");
    return false;
}
else
{
    window.location="afterLogin.html"
}
}
</script>
</head>
<div></div>
<body>
<h1></h1>
    <form name="loginform"  onsubmit="return myFunction();" method="post">
    <div class="username"><label>Username:</label><input type="text" name="user"/></div>
    <div class="password"><label>Password:</label><input type="text" name="pass"/></div>
    <div class="buttons"><input type="button" onclick = "return myFunction()" value="Login" name=""/> <input type="button" value="Cancel" name=""/></div>
</form>

</body>

You might want to start closing your input tags

T J
– T J

2014-03-11 12:20:28 +00:00
Commented Mar 11, 2014 at 12:20 — T J
– T J, Commented Mar 11, 2014 at 12:20
why u dont use jquery?

Nurdin
– Nurdin

2014-03-11 12:23:10 +00:00
Commented Mar 11, 2014 at 12:23 — Nurdin
– Nurdin, Commented Mar 11, 2014 at 12:23

BKM · Accepted Answer · 2014-03-11 12:42:56Z

3

You are already calling the validation function on your form submit onsubmit="return myFunction();". So there isn't any need to call it again on your button click. So please change

 <input type="button" onclick = "return validateForm()" value="Register" name="" class="row1" />

to

 <input type="submit" value="Register" name="" class="row1" />

And do this in your script

<script>
function validateForm()
{
var a=document.forms["regform"]["user"].value;
var b=document.forms["regform"]["pass"].value;
var c=document.forms["regform"]["copa"].value;
var d=document.forms["regform"]["mono"].value;
if(a===""||b===""||c===""||d==="")
{
    alert("Please Enter All the Fields");
    return false;
}
else
{
    window.location="afterregister.html"
    //alert("Registered Successfully");
}
 }
</script>

edited Mar 11, 2014 at 12:42

answered Mar 11, 2014 at 12:25

BKM

7,0797 gold badges32 silver badges47 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

Suresh Peddisetti Over a year ago

If i Change Like this When ever I press Cancel Button it Shows an alert and also for Forgot Password.

BKM Over a year ago

Have you changed <input type="button"> to <input type="submit"> for the login button only?

Suresh Peddisetti Over a year ago

No I changed for all the Buttons.

BKM Over a year ago

Just do it for the register button only and it will solve your problem

BKM Over a year ago

If you want to write code for cancel button make it type="button" and call some function on it's on-click method and do your code in that function. Simple!!!

|

Aniruddha Pondhe · Accepted Answer · 2014-03-11 12:33:37Z

0

Solution: Do the following 2 steps:

1- First close your <input> tags as either of the following method:

i. <input type = "textbox" name = "name" /> 

OR

ii. <input type = "textbox" name = "name"></input>

2- Go through these 2 useful links - it will guide you through what you exactly need:

Form Validation Tutorial - 1

Form Validation Tutorial - 2

answered Mar 11, 2014 at 12:33

Aniruddha Pondhe

1,8803 gold badges18 silver badges30 bronze badges

2 Comments

Dieterg Over a year ago

He has HTML5 doctype so it's not necessary to close your input tags though

Aniruddha Pondhe Over a year ago

@DieterGoetelen Right. I agree. However, as a coding convention and good code practice it advisable to close it.

Collectives™ on Stack Overflow

How to do Form Validation in Javascript

2 Answers 2

7 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

7 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related