Not changing image src attribute through javascript

Question

The following is my current JavaScript code which is not working. I'm trying to change the image.

function imgchange(a)
{
    var e=document.getElementById(a);

     if(e.src == "plus.png")
     {
       e.src = "minus.png";
     }

     else
    {
      e.src="plus.png";
     }

}

Please add the HTML and more information, like what doesn't work to your answer using the edit button. — idmean
– idmean, Commented Mar 13, 2014 at 19:15

nanobash · Accepted Answer · 2014-03-13 19:17:16Z

1

When you are using img.src it returns whole path to img src, not only plus.png

You have to make comparison like http://localhost/images/plus.png (whatever your path is)

or use getAttribute method like is mentioned in undefined's post

answered Mar 13, 2014 at 19:17

nanobash

5,4967 gold badges41 silver badges56 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ram · Accepted Answer · 2014-03-13 19:37:32Z

1

src property includes the full url of the image, try using getAttribute method, which returns the specified value in the HTML.

if ( e.getAttribute("src") === "plus.png" )

Note that means that you should also set the new value using .setAttribute() for future comparisons. If you want to use the .src property you should either compare the full paths or use other methods like regular expression or split method:

if ( e.src.split('/').pop() === "plus.png" )

edited Mar 13, 2014 at 19:37

answered Mar 13, 2014 at 19:17

Ram

145k16 gold badges174 silver badges201 bronze badges

Comments

urz0r · Accepted Answer · 2014-03-13 19:19:46Z

0

the function itself should be working. there must be something wrong at the place you are calling imgchange("xyz").

so maybe you can show us the code where the function is actually called.

answered Mar 13, 2014 at 19:19

urz0r

4623 silver badges9 bronze badges

Comments

Jixun · Accepted Answer · 2014-03-13 19:28:48Z

0

function imgchange (a) {
    var e=document.getElementById(a);
    if (e.src.replace(/.+\//, '') === 'plus.png') {
        e.src = "minus.png";
    } else {
        e.src="plus.png";
    }
}

Should work.

answered Mar 13, 2014 at 19:28

Jixun

14011 bronze badges

Collectives™ on Stack Overflow

Not changing image src attribute through javascript

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related