Check if array is null and has content

Question

I'm in search for some code-improvement. I currently have the following piece of code:

        if (pMyDocAction.s_locatie_st != null)
        {
            String[] myLocaties = Globals.GlobalTools.DeserializeValueToStringArray(pMyDocAction.s_locatie_st);
            if (myLocaties != null)
                if (myLocaties.Length > 0)
                    row.Locatie = myLocaties[0];
                else
                    row.Locatie = String.Empty;
            else
                row.Locatie = String.Empty;
        }
        else
            row.Locatie = String.Empty;

Mylocaties is a Array of String and this cannot change. How can i shorten this piece of code (or how can i combine the != null and .length > 0?

Thnx

Thnx everyone for the quick answers! If learned lots of new ways to tackle the mentionned problem. +1 to everyone! I will give the credits to selman though as he was to quickest poster and i'm using a variant of his code. Also a great thnx to CodeCaster for pointing out that this code might be better suited in my Globals class! — User999999
– User999999, Commented Mar 17, 2014 at 14:58

Selman Genç · Accepted Answer · 2014-03-17 14:50:33Z

2

You can use conditional operator and write that statement like this:

row.Locatie =  (myLocaties != null && 
                myLocaties.Length > 0) ? myLocaties[0] : String.Empty

answered Mar 17, 2014 at 14:50

Selman Genç

102k15 gold badges126 silver badges193 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

RB. Over a year ago

The null-coalescing operator is ??, not ?.

Steve B · Accepted Answer · 2014-03-17 15:16:05Z

2

I would suggest you to create a small extension method:

public static class ArrayExtension{
    public static bool HasContent<T>(Array<T> array) {
         return array != null && array.Length > 0;
    }
}

Then you can check :

int[] x = null;

x.HasContent(); // false

string[] strs = new string[] {};

strs.HasContent(); // false

string[] strs2 = new string[] {"foo", "bar" };

strs.HasContent(); // true

This can be extended to simplify your syntax:

public static class ArrayExtension{
    public static T FirstValueOrDefault<T>(Array<T> array, T @default) {
         if( array != null && array.Length >0 ){
              return array[0];
         }
         else {
              return @default;
         }
    }
}


int[] x = null;

int y = x.FirstValueOrDefault(42); // 42

string[] strs = new string[] {};

string some = strs.FirstValueOrDefault("default"); // default

string[] strs2 = new string[] {"foo", "bar" };

 string some2 = strs.FirstValueOrDefault("default"); // foo

edited Mar 17, 2014 at 15:16

answered Mar 17, 2014 at 14:52

Steve B

38k24 gold badges109 silver badges186 bronze badges

1 Comment

enorl76 Over a year ago

I like this semantic. I would name it a little different, but nothing comes to mind right away :)

Habib · Accepted Answer · 2014-03-17 14:49:45Z

1

Use && operator on two conditions, it will do short-circuit evaluation and if first condition is false, it will not evaluate the second condition.

if (myLocaties != null && myLocaties.Length > 0)
{
    row.Locatie = myLocaties[0];
}
else
{
   row.Locatie = String.Empty;
}

answered Mar 17, 2014 at 14:49

Habib

224k30 gold badges420 silver badges446 bronze badges

Comments

CodeCaster · Accepted Answer · 2014-03-17 14:53:18Z

Since all other answers seem to ignore the if (pMyDocAction.s_locatie_st != null), something like this seems to be the most reusable:

row.Locatie = DeserializeLocation(pMyDocAction.s_locatie_st);

string DeserializeLocation(string locationString)
{
    var result = "";

    if (!string.IsNullOrEmpty(locationString))
    {
        String[] deserializedLocations = 
            Globals.GlobalTools.DeserializeValueToStringArray(locationString);

        if (deserializedLocations != null && deserializedLocations.Any())
        {
            result = deserializedLocations[0];
        }
    }   

    return result;
}

You might even consider putting this method in your "GlobalTools" class, so you can call it from anywhere were you need to deserialize a potentially null-bearing serialized location string into a location string.

Collectives™ on Stack Overflow

Check if array is null and has content

4 Answers 4

1 Comment

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related