Add String to an ArrayList if only not empty

Question

Supposing I have an ArrayList < String > named arr and a StringBuilder named buf, I use the following method to add the contents of buf to arr.

if ( !buf.toString( ).equals( "" ) ) {  //allow only non-empty Strings.
    arr.add( buf.toString( ) );
}

But it calls buf.toString( ) twice. I don't want that in my code. Moreover, is there any other (short or easy or efficient or something else) way to achieve this?

EDIT: Also, I do this in a loop, so is this efficient?

String s = buf.toString(); and use s?

fge
– fge

2014-03-19 11:59:21 +00:00
Commented Mar 19, 2014 at 11:59 — fge
– fge, Commented Mar 19, 2014 at 11:59

Abimaran Kugathasan · Accepted Answer · 2014-03-19 12:35:09Z

5

There is API String#isEmpty() method to check empty Strings in Java, use it. It will be more elegant.

String temp = buf.toString();

if (!temp.isEmpty()) {
    arr.add(temp);
}

edited Mar 19, 2014 at 12:35

answered Mar 19, 2014 at 11:59

Abimaran Kugathasan

32.7k11 gold badges81 silver badges109 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Hungry Blue Dev Over a year ago

Hmm... didn't know that. Thanks. (Are there more such elegant methods)?

Abimaran Kugathasan Over a year ago

@ambigram_maker, Yes, Check APIs.

Sergey Shustikov · Accepted Answer · 2014-03-19 12:04:34Z

2

I think you need a length() method instead of toString because is a call for super class method and create new instance of String so i recommend you a next :

if(buf.length()>0)
{
  arr.add(buf.toString()); // one call!
}

answered Mar 19, 2014 at 12:04

Sergey Shustikov

15.9k12 gold badges72 silver badges127 bronze badges

Collectives™ on Stack Overflow

Add String to an ArrayList if only not empty

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related