jQuery: Dynamic URL

Question

I have a number of urls, and I'm wondering if there's a way to dynamically change the last digit of them.

    <div class="m_item">
        <a class="thumbnail_link" href="http://paraboladesignstudio.ipage.com/yahaira/fashion/fashion-slideshow/?thumb=0">
            <img src="<?php echo $image['sizes']['thumbnail'];?>" title="<?php echo $image['title'];?>" alt="<?php echo $image['alt']; ?>"> 
        </a>
    </div>

The above code outputs certain number of ".m_item"s with the same "a href"s.

This is my jQuery code:

var i=0;
i++;

$(".thumbnail_link").each(function() {
    this.href = this.href.replace("0", i);
});

It changed all the urls to "..../?thumb=1"

How could I make the digit increase? I've tried .children with no luck.

Thank you.

At least try: $(".thumbnail_link").each(function(i) { this.href = this.href.replace("0", i); }); and remove your i declaration — A. Wolff
– A. Wolff, Commented Mar 19, 2014 at 19:08

Huangism · Accepted Answer · 2014-03-23 00:47:10Z

3

Get rid of the i and just use the index of the each() https://api.jquery.com/each/

$(".thumbnail_link").each(function(index) {
    this.href = this.href.replace("0", index);
});

Or you can do this in case there are other 0s in the url

$(".thumbnail_link").each(function(index) {
    this.href = this.href.replace("thumb=0", "thumb=" + index);
});

edited Mar 23, 2014 at 0:47

answered Mar 19, 2014 at 19:08

Huangism

16.5k7 gold badges51 silver badges75 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

Nisam Over a year ago

what happened when the url string have other "0" s ..?

Huangism Over a year ago

From the way the OP asked, it seems there is only one 0, but you can always replace the entire thumb=0

Jaeeun Lee Over a year ago

Thank you, but then the url starts from 1, but it should start from 0. I tried i-1 but only got an error.

Nisam Over a year ago

now the answer more close to his needs i think +1 for u

Huangism Over a year ago

Just take 1 off from the index

|

Justin Morgan · Accepted Answer · 2014-03-20 19:19:50Z

2

It's doing that because i is only ever incremented once. It starts out as zero, then you bump it up to 1 with i++, and then you never change it again. Try this:

$(".thumbnail_link").each(function(i) {
    this.href = "http://paraboladesignstudio.ipage.com/yahaira/fashion/fashion-slideshow/?thumb=" + i;
});

edited Mar 20, 2014 at 19:19

answered Mar 19, 2014 at 19:09

Justin Morgan

30.7k13 gold badges82 silver badges109 bronze badges

Comments

Sajjad Ashraf · Accepted Answer · 2014-03-19 19:43:43Z

1

or if you want to update the last number, use this

$(".thumbnail_link").each(function(index) {
    this.href = this.href.replace(/([\d]+)$/g, index);
});

answered Mar 19, 2014 at 19:43

Sajjad Ashraf

3,8741 gold badge37 silver badges36 bronze badges

Collectives™ on Stack Overflow

jQuery: Dynamic URL

3 Answers 3

7 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

7 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related