Javascript append to variable

Question

        var gen = "            scrollwheel: true,\n"+
              "            streetViewControl: true,\n";

    if (val == "FALSE"){
                gen = "            control: false,\n";
                } else {
                gen = "            control: true,\n";
    }
gen = "            zoom: true,\n";

What would be the best way to append the gen variable so that everything gets added one after the other.

So many things look wrong is so little code... Why are you comparing to the string FALSE and not the boolean false? Why are you creating what is essentially an object with strings? What happened to the indentation? — elclanrs
– elclanrs, Commented Mar 22, 2014 at 13:51

p.s.w.g · Accepted Answer · 2014-03-22 13:58:18Z

4

You could use the += operator as a convenient way to append strings:

var gen = "            scrollwheel: true,\n"+
          "            streetViewControl: true,\n";

if (val == "FALSE"){
     gen += "            control: false,\n";
} else {
     gen += "            control: true,\n";
}
gen += "            zoom: true,\n";

^{Note: gen += "foo" is equivalent to get = gen + "foo".}
But in this case, I think the conditional operator (?:) is simpler:

var gen = "            scrollwheel: true,\n"+
          "            streetViewControl: true,\n" +
          "            control: " + (val == "FALSE" ? "false" : "true") + ",\n" +
          "            zoom: true,\n";

Or if the intent is to create a JSON string, just create the object directly:

var gen = {
    scrollwheel: true,
    streetViewControl: true,
    control: val != "FALSE",
    zoom: true
};

And then turn it into a string using JSON.stringify.

edited Mar 22, 2014 at 13:58

answered Mar 22, 2014 at 13:52

p.s.w.g

150k31 gold badges307 silver badges339 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Javascript append to variable

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related