Angular Service is injected into controller, but it appears as an empty object

Question

I have the following angular service.

angular.module('myApp')
.service('StatusService', function StatusService() {
    var statusService= {
        show: 'off',
        on: function() {
            this.show = 'on';
        },
        off: function() {
            this.show = 'off';
        }
    };

    return statusService;
});

Which is injected into a controller, and its on function is invoked, like this:

angular.module('myApp')
    .controller('aController', function (StatusService) {

    StatusService.on(); 
})

But I get the following error.

TypeError: Object #<Object> has no method 'on'

user2412555 · Accepted Answer · 2016-04-02 20:59:58Z

1

You will get this problem if you declared multiple service with the same name in different places, it got confused and will return an {}.

answered Apr 2, 2016 at 20:59

user2412555

1,0551 gold badge18 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Nikita · Accepted Answer · 2014-03-25 01:36:23Z

1

I think you're using a module.service() invocation with module.factory() implementation when declaring the service. either change the earlier to module.factory(StatusService) (which should really be called StatusServiceFactory) OR change impl to add interface methods to StatusService itself ie:

function StatusService(){
this.show='off';
this.on = function(){};
}
module.service('statusService', StatusService);

Here's a demo of the above working: http://plnkr.co/edit/r07kPP85oQQKtJYMYOyK?p=preview

edited Mar 25, 2014 at 1:36

answered Mar 24, 2014 at 17:12

Nikita

6,1498 gold badges48 silver badges56 bronze badges

1 Comment

criver.to Over a year ago

I changed the type of service to a factory, but the same issue is still occurring. I have always used the same implementation, using service('aservice'), and I have been able to use the service to store data. Basically I just want to be able to change the show to 'on' or 'off' using the methods on() and off().

Collectives™ on Stack Overflow

Angular Service is injected into controller, but it appears as an empty object

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related