Javascript accessing local variable from other function

Question

Okay I have this problem. I am using this variable in one function, but I have to reset it in another, but I'm not sure how to accomplish it.

My code looks like this:

var city_flag = null;
  $(".button").click(function(){
    var city = $(this).attr("id");

    if(city_flag == city){
      city_flag = null;
    } else {
      city_flag = city;
    }
  });

And than I got this: (coffescript)

$.fn.extend
  somelistMap: (options) ->
    // some settings here

   // on init addCloseClickListenerToInfoWindow called

  addCloseClickListenerToInfoWindow = (id) =>
      google.maps.event.addListener markers[id]["infoWindow"], 'closeclick', =>
        resetMap()
        $(".city_tab").css("background", "none")
        $(".all_dealers").removeClass("row_hide")
        $(".all_dealers").addClass("row_show")
        city_flag = null //Here i have to reset it

How can I get this to work? I tried putting city flag outside of the functions, but its not working!

EDIT: Forgot to mention environment is rails.. if that changes something

declare that variable as GLOBAL

Praveen
– Praveen

2014-03-25 12:35:48 +00:00
Commented Mar 25, 2014 at 12:35 — Praveen
– Praveen, Commented Mar 25, 2014 at 12:35
put var city_flag outside your document.ready

JF it
– JF it

2014-03-25 12:36:35 +00:00
Commented Mar 25, 2014 at 12:36 — JF it
– JF it, Commented Mar 25, 2014 at 12:36
ok i will try that....sec

user2945241
– user2945241

2014-03-25 12:37:09 +00:00
Commented Mar 25, 2014 at 12:37 — user2945241
– user2945241, Commented Mar 25, 2014 at 12:37
flag or city_flag you seem to be interchanging them

Patrick Evans
– Patrick Evans

2014-03-25 12:37:40 +00:00
Commented Mar 25, 2014 at 12:37 — Patrick Evans
– Patrick Evans, Commented Mar 25, 2014 at 12:37
sorry my bad, in code this was right ;)

user2945241
– user2945241

2014-03-25 12:43:16 +00:00
Commented Mar 25, 2014 at 12:43 — user2945241
– user2945241, Commented Mar 25, 2014 at 12:43

Jeremy Danyow · Accepted Answer · 2014-03-25 12:38:08Z

2

declaring global variables is not a best practice but it will solve this specific problem.

use this whenever you access city_flag: window.city_flag.

for example:

window.city_flag = null;

or

window.city_flag = city;

answered Mar 25, 2014 at 12:38

Jeremy Danyow

26.5k12 gold badges92 silver badges137 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user2945241 Over a year ago

I tried this already too. nothing seems to change! 'city_flag' does not reset!

Rohan Kumar · Accepted Answer · 2014-03-25 12:37:26Z

1

Make city_flag as a GLOBAL var like,

var flag = null,
    city_flag = null;
// ..... your remaining code

Also you can use this.id instead of $(this).attr("id") like,

var city = this.id;

answered Mar 25, 2014 at 12:37

Rohan Kumar

40.7k11 gold badges81 silver badges111 bronze badges

Comments

vimal1083 · Accepted Answer · 2014-03-25 12:46:58Z

0

To get this work do the below changes (I dont know your Full coffeescript structure , this is just a assumption)

$.fn.extend
  somelistMap: (options) ->
    // some settings here

   // on init addCloseClickListenerToInfoWindow called
//////////////////
  var that = this;
///////////////
  addCloseClickListenerToInfoWindow = (id) =>
      google.maps.event.addListener markers[id]["infoWindow"], 'closeclick', =>
        resetMap()
        $(".city_tab").css("background", "none")
        $(".all_dealers").removeClass("row_hide")
        $(".all_dealers").addClass("row_show")
        that.city_flag = null //Here i have to reset it

answered Mar 25, 2014 at 12:46

vimal1083

8,6916 gold badges36 silver badges50 bronze badges

Comments

user2945241 · Accepted Answer · 2014-03-25 13:01:07Z

0

Okey...i tried everything mentioned, nothing seemed to work :/

So i came up with this solution, i created hidden element and just took my value with ("#hidden").html() and to reset it ("#hidden").html("null")

I know it is not the best solution, but this workaround worked!

answered Mar 25, 2014 at 13:01

user2945241

3605 silver badges19 bronze badges

Collectives™ on Stack Overflow

Javascript accessing local variable from other function

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related