Rails: ruby code in javascript

Question

I have a problem with a passing ruby code in javascript script tag

Now I have this code:

<script>
  var offer_foto = {
    slide_offer_preview_1: ['one.jpg', 'two.jpg', 'three.jpg'],
    slide_offer_preview_2: ['four.jpg', 'five.jpg', 'six.jpg']
  }
</script>

My Ruby code

<% for i in 0..@page[:proposals].count - 1 %>
  <%= @page[:proposals][i][:hotels][0]['hotel_images'].map{|f| f['url']} %>
<% end %>

In Javascript I need

slide_offer_preview_i: <%= @page[:proposals][i][:hotels][0]['hotel_images'].map{|f| f['url']} %>

Unfortunately I don't know how ti get it because I know Javascript not quite well. If you need more information please comment. Thanks!

000 · Accepted Answer · 2014-03-25 16:15:17Z

1

You should do this in the controller, not in the template. Keep logic far away from your templates.

In your controller:

@slide_offer_previews = []
for i in 0..@page[:proposals].count - 1
  @slide_offer_previews << @page[:proposals][i][:hotels][0]['hotel_images'].map{|f| f['url']}
end

Then in your view:

slide_offer_preview_i: <%= @slide_offer_previews[i] %>

Alternatively, if @page[:proposals][i] is an object, then add a method to your class:

def hotel_image_urls
  self[:hotels][0]['hotel_images'].map{|f| f['url']}
end

then in your view:

slide_offer_preview_i: <%= @page[:proposals][i].hotel_image_urls() %>

edit: Sorry, this doesn't even make syntactical sense. Disregard this alternate.

edited Mar 25, 2014 at 16:15

answered Mar 25, 2014 at 16:09

000

27.3k10 gold badges74 silver badges103 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

NM Pennypacker · Accepted Answer · 2014-03-25 16:12:34Z

0

I'm with Joe Frembach, you should do this in the controller. However, if you do need to embed Ruby into Javascript, you can do so by adding .erb (file_name.js.erb) to the file extension, in which case you can do something like:

alert('<%= @your_embedded_variable %>');

answered Mar 25, 2014 at 16:12

NM Pennypacker

6,99211 gold badges38 silver badges41 bronze badges

1 Comment

000 Over a year ago

I'm okay with this as long as any minifiers are aware that this js is not cacheable. The js would need to be generated every page load, and is an extra request.

Collectives™ on Stack Overflow

Rails: ruby code in javascript

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related