Spring MVC: RequestMapping both class and method

Question

Is this possible?

@Controller
@RequestMapping("/login")
public class LoginController {

    @RequestMapping("/")
    public String loginRoot() {
        return "login";
    }

    @RequestMapping(value="/error", method=RequestMethod.GET)
    public String loginError() {
        return "login-error";
    }

}

I got a 404 error when accessing localhost:8080/projectname/login but not in localhost:8080/projectname/login/error.

Here's my web.xml project name

<listener>
    <listener-class>
        org.springframework.web.context.ContextLoaderListener
    </listener-class>
</listener>

<context-param>
    <param-name>contextConfigLocation</param-name>
    <param-value>/WEB-INF/applicationContext.xml</param-value>
</context-param>

<servlet>
    <description></description>
    <servlet-name>projectname</servlet-name>
    <servlet-class>
        org.springframework.web.servlet.DispatcherServlet
    </servlet-class>
</servlet>

<servlet-mapping>
    <servlet-name>projectname</servlet-name>
    <url-pattern>/</url-pattern>
</servlet-mapping>

chrylis -cautiouslyoptimistic- · Accepted Answer · 2014-03-28 01:41:55Z

29

You don't need the / in the method's mapping. Just map it to "".

answered Mar 28, 2014 at 1:41

chrylis -cautiouslyoptimistic-

77.5k21 gold badges127 silver badges167 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Sotirios Delimanolis Over a year ago

And this will work because "" will be relative to "/login" so still /login.

Binz · Accepted Answer · 2014-03-28 01:48:23Z

11

You don't need to "/" and you need to also add the request method.

@RequestMapping(method = RequestMethod.GET)
public String loginRoot() {
    return "login";
}

Consider using spring mvc tests to make the process of testing these scenarios easier:

https://spring.io/blog/2012/11/12/spring-framework-3-2-rc1-spring-mvc-test-framework

answered Mar 28, 2014 at 1:48

Binz

1235 bronze badges

2 Comments

Binz Over a year ago

Just ran a quick test, in your case you can just have @RequestMapping and it will work. The request method is GET by default.

Sotirios Delimanolis Over a year ago

@BineshGunaratne The request method is not GET by default. If you omit the method attribute, all request methods will be matched.

Sotirios Delimanolis · Accepted Answer · 2014-03-28 01:51:24Z

6

Yes that is possible. The path in @RequestMapping on the method is relative to the path on the class annotation.

With your current setup, loginRoot() will handle requests to

localhost:8080/projectname/login/

Assuming you don't have anything else in your configuration preventing this.

edited Mar 28, 2014 at 1:51

answered Mar 28, 2014 at 1:37

Sotirios Delimanolis

281k62 gold badges718 silver badges744 bronze badges

7 Comments

Orvyl Over a year ago

that's what I believe too but Im getting a 404 error accessing localhost:8080/projectname/login and I dont know why, did I miss something?

nickdos Over a year ago

Do you have a JSP named "login.jsp" in the same directory as your "error.jsp"?

Sotirios Delimanolis Over a year ago

@orvyl It works for me. Can we see your web.xml and servlet context configuration? Your mappings are probably different and preventing this.

chrylis -cautiouslyoptimistic- Over a year ago

@SotiriosDelimanolis What Spring version are you using? I just ran into a very similar issue with 4.0.0.RELEASE, and using an empty mapping string fixed it. Note that the question doesn't have the trailing slash on the URL, and yours does.

Sotirios Delimanolis Over a year ago

@chrylis I'm on 4.0.2. This behavior has existed since at least 3.1, iirc. I'm suggesting they change from using /login to using /login/ for the request to reach the handler. Again, this might be an issue with the rest of the configuration.

|

Collectives™ on Stack Overflow

Spring MVC: RequestMapping both class and method

3 Answers 3

1 Comment

2 Comments

7 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

2 Comments

7 Comments

Your Answer

Sign up or log in

Post as a guest

Related