Error java.lang.ArrayIndexOutOfBoundsException:

Question

I pass string value to this method.but im getting Array index bound exception please help me.

public void separateCards(String cards)
{
    cardNames+=cards+"-";
    String[] parts = cardNames.split("-");
    String part1 = parts[0]; // 004
    String part2 = parts[1]; // 034556
    Toast.makeText(getActivity(), part1,Toast.LENGTH_SHORT).show();
}
}

My logcat

  03-28 11:27:41.213: E/AndroidRuntime(22392): FATAL EXCEPTION: main
    03-28 11:27:41.213: E/AndroidRuntime(22392): java.lang.ArrayIndexOutOfBoundsException: length=1; index=1
    03-28 11:27:41.213: E/AndroidRuntime(22392):    at com.compareCr.ListvCompare.separateCards(ListvCompare.java:760)
    03-28 11:27:41.213: E/AndroidRuntime(22392):    at com.compareCr.ListvCompare$2$1.onClick(ListvCompare.java:627)
    03-28 11:27:41.213: E/AndroidRuntime(22392):    at android.view.View.performClick(View.java:4261)
    03-28 11:27:41.213: E/AndroidRuntime(22392):    at android.view.View$PerformClick.run(View.java:17356)
    03-28 11:27:41.213: E/AndroidRuntime(22392):    at android.os.Handler.handleCallback(Handler.java:615)
    03-28 11:27:41.213: E/AndroidRuntime(22392):    at android.os.Handler.dispatchMessage(Handler.java:92)

what is your String that you are attempting to split over - — Jigar Joshi
– Jigar Joshi, Commented Mar 28, 2014 at 6:07
@Apoorv its cardName just like GoldeCard-platinumcard like that — Rehan K
– Rehan K, Commented Mar 28, 2014 at 6:08
Use this: cardNames+="-"+cards;. If u understand it, i'll add an answer. — Hungry Blue Dev
– Hungry Blue Dev, Commented Mar 28, 2014 at 6:08

Waqar Ahmed · Accepted Answer · 2014-03-28 06:09:33Z

3

you append "-" at the end of the string and therefore when you split , you get only one value.

therefore this String part2 = parts[1]; throw array index out of bound exception.

you need to put "-" in between string.

answered Mar 28, 2014 at 6:09

Waqar Ahmed

5,0883 gold badges28 silver badges46 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Hungry Blue Dev Over a year ago

I grant you permission to use the code from my comment: cardNames+="-"+cards; :-)

Waqar Ahmed Over a year ago

thank you but i dont think to add that here. because i guess the question man has understand what was the problem.....:p

Niranj Patel · Accepted Answer · 2014-03-28 06:23:29Z

1

I think there is only single "-" in your cardNames value, that's why you getting error..

So better to use For loop for getting all data from Array

    String[] parts = cardNames.split("-");
    for (int i = 0; i < parts.length; i++) {
        String partsData = parts[i]; 
    }

Updated:

cardNames=cardNames+"-"+cards;

String parts1;
String parts2;
String[] parts = cardNames.split("-");
for (int i = 0; i < parts.length; i++) {
    if(i==0)
        parts1= parts[i];
    else if(i==1)
        parts2= parts[i];
}

edited Mar 28, 2014 at 6:23

answered Mar 28, 2014 at 6:10

Niranj Patel

33.3k11 gold badges101 silver badges137 bronze badges

2 Comments

Rehan K Over a year ago

i want to divide becouse i want to save in two strings.how do i do that please help me

Niranj Patel Over a year ago

First you merge two string after then you divide it, why this so ??

Baby · Accepted Answer · 2014-03-28 06:25:32Z

1

You add the - in the wrong place. Giving you the value as(I assume the initial value of cardNames is 004)

"004034556-"

You should do:

cardNames += "-" +cards;

Which will give you:

"004-34556"

But seriously what is the purpose of combining the String and split it again at the same way?

Wouldn't it be easy if you just do like this?

String part1 = cardNames; 
String part2 = cards;

Note: You should always check that the index element that you want to access must less that parts.length

edited Mar 28, 2014 at 6:25

answered Mar 28, 2014 at 6:09

Baby

5,1123 gold badges33 silver badges53 bronze badges

1 Comment

Hungry Blue Dev Over a year ago

Care to explain how this happens?

rabbit.aaron · Accepted Answer · 2014-03-28 06:11:04Z

0

When something with no "-" passed into your method, like "foo" it become "foo-" when u call "foo-".split() it returns ["foo"] therefore if u try to access index 1, it is out of bound.

answered Mar 28, 2014 at 6:11

rabbit.aaron

2,64719 silver badges27 bronze badges

Comments

chris · Accepted Answer · 2014-03-28 06:11:51Z

-1

Have you print "cards"?

I think cardNames is "somethig-"; then parts = {'something'}

so, parts[1] is out of index.

answered Mar 28, 2014 at 6:11

chris

831 silver badge7 bronze badges

Collectives™ on Stack Overflow

Error java.lang.ArrayIndexOutOfBoundsException:

5 Answers 5

2 Comments

2 Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

2 Comments

2 Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related