PHP. Fatal error: Using $this when not in object context

Question

I've got a problem

I'm new to PDO, so i'm trying to get all data from a tabla, very easy i know, but $this variable is giving me some problem, i wrote a class called DB to connect to mysql, and i use it in another class called getAll with a function called get;

DB class

<?php 
class DB
{
    private $_dbh;
    private static $_instance;
    private function __construct()
    {
        try 
        {
            $this->_dbh = new PDO("mysql:host=127.0.0.1;dbname=telmex","root","a.d.s.l");                   
        } 
        catch (PDOException $e) 
        {
            die($e->getMessage());  
        }
    }

    public static function Link()
    {
        if(!isset(self::$_instance))
        {
            self::$_instance = new DB();
        }

        return self::$_instance;    
    }
}

?>

getAll Class

<?php 

class getAll
{
    public $_dbh;
    public function __construct()
    {
        $this->_dbh=DB::Link();
    }

    public static function get($tabla)
    {
        $sql="SELECT * FROM ".$tabla."";
        if($sentencia=$this->_dbh->prepare($sql))
        {
            echo "Prepared.";
        }   
    }
} ?>

So when i run

<?php 
$select = new getAll();
    $consultar = $select->get("users");
 ?>

it gives me a fatal error.

remove the static from the definition of public static function get($tabla) because you're not calling it statically, you're treating it as an instance method — Mark Baker
– Mark Baker, Commented Mar 28, 2014 at 17:42

Anri · Accepted Answer · 2014-03-28 17:59:42Z

0

remove this line from getAll class public $_dbh; and make it extend of DB class

edited Mar 28, 2014 at 17:59

answered Mar 28, 2014 at 17:45

Anri

1,7032 gold badges18 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Mark Baker Over a year ago

Except there won't be a valid database connection unless you make a few other changes as well

Anri Over a year ago

can you write exactly what is the problem from apache log ?

DaveSanchez Over a year ago

Fatal error: Using $this when not in object context in /var/www/html/PDO/Clases/getAll.php on line 14

Anri Over a year ago

remove this line from getAll class public $_dbh; and make it extend of DB class

jeddey · Accepted Answer · 2014-12-31 00:36:23Z

0

<?php 
class getAll extends DB {
    public function __construct()
    {
       parent::__construct();
    }
    public static function get($tabla)
    {
        $sql="SELECT * FROM ".$tabla."";
        if($sentencia=$this->_dbh->prepare($sql))
        {
            echo "Prepared.";
        }   
    } 
 }
getAll::get('users');
 ?>

edited Dec 31, 2014 at 0:36

answered Dec 31, 2014 at 0:11

jeddey

552 silver badges13 bronze badges

Comments

Dunkel Kruspe · Accepted Answer · 2015-06-27 18:34:53Z

DB class

<?php 
class DB
{
    var $_dbh;
    private static $_instance;
    private function __construct()
    {
        try 
        {
            $this->_dbh = new PDO("mysql:host=127.0.0.1;dbname=telmex","root","a.d.s.l");                   
        } 
        catch (PDOException $e) 
        {
            die($e->getMessage());  
        }
    }
    function get_dbh(){
        return $this->_dbh;  
    }
    public static function Link()
    {
        if(!isset(self::$_instance))
        {
            self::$_instance = new DB();
        }

        return self::$_instance;    
    }
}
?>

getAll Class

<?php 

class getAll
{
    public $_dbh;
    public function __construct()
    {
        $con = DB::Link();
        $this->_dbh= $con->get_dbh();
    }

    public static function get($tabla)
    {
        $sql="SELECT * FROM ".$tabla."";
        if($sentencia=$this->_dbh->prepare($sql))
        {
            echo "Prepared.";
        }   
    }
} ?>

Collectives™ on Stack Overflow

PHP. Fatal error: Using $this when not in object context

3 Answers 3

4 Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

4 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related