doubly linked list C implementation runtime error

Question

Below is the C program I have written. It contains an implementation of the doubly linked list.

#include <stdio.h>

/* node of a doubly linked list */
typedef struct _dlnode {
    struct _dlnode* prev;
    int key;
    struct _dlnode* next;
} dlnode;

/* doubly linked list */
typedef struct _dllist {
    dlnode* head;
    dlnode* tail;
} dllist;

/* returns an empty doubly linked list */
dllist* empty_dllist () {
    dllist* l;
    l->head=NULL;
    l->tail=NULL;
    return l;
}

int main()
{
    dllist* l;
    l=empty_dllist ();
    return 0;
}

I get the following runtime error:

Segmentation fault: 11

What is it caused by?

ajay · Accepted Answer · 2014-03-29 10:45:37Z

1

You have to allocate memory for a structure before you use a pointer to it to access its members. Change your function empty_dllist to -

dllist *empty_dllist(void) {
    dllist *l = malloc(sizeof *l);
    if(l == NULL) {
        // failed to allocate memory
        // handle it
        // return NULL
    }
    l->head = NULL;
    l->tail = NULL;
    return l;
}

answered Mar 29, 2014 at 10:45

ajay

9,6909 gold badges47 silver badges72 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Thomas Padron-McCarthy · Accepted Answer · 2014-03-29 10:43:48Z

0

A segmentation fault is usually caused by trying to follow an uninitialized or NULL pointer.

In your program, you have pointer variable l in the function empty_dllist, and you try to follow that pointer to what it points to. But the variable is uninitialized, and cointains garbage, so it is not surprising that you get a segmentation fault.

You probably want to add a call to malloc in empty_dllist, to allocate a header struct for your list.

answered Mar 29, 2014 at 10:43

Thomas Padron-McCarthy

27.7k8 gold badges55 silver badges77 bronze badges

Comments

Spock77 · Accepted Answer · 2014-03-29 10:44:40Z

0

You are not allocating memory:

dllist* l = malloc(sizeof(dllist));

so trying to access l->head causes error memory access

answered Mar 29, 2014 at 10:44

Spock77

3,3352 gold badges32 silver badges41 bronze badges

Collectives™ on Stack Overflow

doubly linked list C implementation runtime error

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related