Convert Linq to Sql query into better sql

Question

So I need some with a sql query. The sql generated from linq is very subpar it seems and the stored procedure times out.

Here's what i'm trying to do.

Two tables, look like this:

dbo.Links
-------------
Id
Url
Title

And another one that looks like this

dbo.Link_Counts
-----------------
Url
Count

What I would like to do is write a sql query that does this

var linkCounts = Links.GroupBy(x => x.Url)
                 .Select(grp => new Link_Counts 
                  {
                      Url = grp.First().Url,
                      Count = grp.Count()
                  });

InsertAllOnSubmit(linkCounts);
SubmitChanges();

The sql that I attempted to use that is partly generated from this is

    INSERT INTO Link_Counts (Url, Count)
SELECT (
    SELECT [t3].[URL]
    FROM (
        SELECT TOP (1) [t2].[URL]
        FROM [Links] AS [t2]
        WHERE (([t1].[URL] IS NULL) AND ([t2].[URL] IS NULL)) OR (([t1].[URL] IS NOT NULL) AND ([t2].[URL] IS NOT NULL) AND ([t1].[URL] = [t2].[URL]))
        ) AS [t3]
    ) AS [Url], [t1].[value] AS [Count]
FROM (
    SELECT COUNT(*) AS [value], [t0].[URL]
    FROM [Links] AS [t0]
    GROUP BY [t0].[URL]
    ) AS [t1]
END

Where apparently is too long running for a stored procedure.

Any help would be greatful.

Thanks

Justin Niessner · Accepted Answer · 2014-03-29 21:11:27Z

3

If you want to write the SQL by hand:

insert into link_counts (url, count)
select url, count(0)
from links
group by url

Or, if you just want to fix the LINQ query to generate better SQL:

var linkCounts = 
    Links.GroupBy(x => x.Url)
         .Select(g => new Link_Counts
             {
                 Url = g.Key,
                 Count = g.Count()
             };

answered Mar 29, 2014 at 21:11

Justin Niessner

246k40 gold badges416 silver badges546 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Szymon · Accepted Answer · 2014-03-29 21:08:55Z

2

I think this is what you need to insert the count for each url:

insert into Link_Counts (Url, Count)
select Url, Count(*)
from dbo.Links
group by Url

answered Mar 29, 2014 at 21:08

Szymon

43k16 gold badges99 silver badges115 bronze badges

Collectives™ on Stack Overflow

Convert Linq to Sql query into better sql

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related