Java PriorityQueue Comparator - How/When do you sort?

Question

I'm initialising a Priority Queue like:

strategy = new FuelPriority();
incoming = new PriorityQueue<Vehicle>(1, strategy);

The code for my Comparator class is:

public class FuelPriority implements Comparator<Object> {

public int compare(Object o1, Object o2) {

    Vehicle a1 = (Vehicle) o1;
    Vehicle a2 = (Vheicle) o2;

    return Integer.compare(a1.getFuelLevel(), a2.getFuelLevel());
  }
}

After running a simulation, the elements aren't ordered at all - they are random; I set a breakpoint in the compare method of my FuelPriority class, but it wasn't called at all. Am I missing something here?

Alexandre Santos · Accepted Answer · 2014-04-01 20:05:20Z

3

Aside from the typo on your code, it works for me.

import java.util.Comparator;
import java.util.PriorityQueue;

public class StackOverflow
{
    public static void main(String[] args)
    {

        FuelPriority strategy = new FuelPriority();
        PriorityQueue<Vehicle> incoming = new PriorityQueue<Vehicle>(4, strategy);
        incoming.add(new Vehicle("car1", 10));
        incoming.add(new Vehicle("car2", 20));
        incoming.add(new Vehicle("car3", 15));
        incoming.add(new Vehicle("car4", 1));

        // to retrieve the elements in order
        while (!incoming.isEmpty()) {
            System.out.println(incoming.poll());
        }

    }

}

class FuelPriority
    implements Comparator<Object>
{

    public int compare(Object o1, Object o2)
    {

        Vehicle a1 = (Vehicle)o1;
        Vehicle a2 = (Vehicle)o2;

        return Integer.compare(a1.getFuelLevel(), a2.getFuelLevel());
    }
}

class Vehicle
{

    private String name;
    private int fuelLevel;

    public Vehicle(String name, int fuelLevel)
    {
        this.name = name;
        this.fuelLevel = fuelLevel;
    }
    public int getFuelLevel()
    {
        return fuelLevel;
    }

    @Override
    public String toString()
    {
        return name + "=" + fuelLevel;
    }
}

edited Apr 1, 2014 at 20:05

answered Apr 1, 2014 at 18:01

Alexandre Santos

8,37810 gold badges48 silver badges66 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Connor Cartwright Over a year ago

It seems to be ordering, but not completely/correctly, here is the output of a run: 13, 16, 27, 21, 19, 39, 37, 50, 30, 34, 64, 46, 49, 72, 59, 58, 55, 61, 47, 73. I've tried it on a few different seeds, and the lowest fuel level is always at the front of the queue, but I don't know why the rest of the objects aren't ordered correctly.

Alexandre Santos Over a year ago

If you want to retrieve the values in sorted order, use poll or peek. Specifically, change the System.out.println(incoming) with while (!incoming.isEmpty()) { System.out.println(incoming.poll()); }

committedandroider Over a year ago

@AlexandreSantos can you take a look at my use of PriorityQueue in this question? stackoverflow.com/questions/28800287/…

Evgeniy Dorofeev · Accepted Answer · 2014-04-01 17:50:52Z

2

API says that PriorityQueue iterator is not guaranteed to traverse the elements of the priority queue in any particular order. It's only guaranteed that poll, remove, peek, and element access the element at the head of the queue (least element)

answered Apr 1, 2014 at 17:50

Evgeniy Dorofeev

137k31 gold badges209 silver badges288 bronze badges

1 Comment

committedandroider Over a year ago

Can you take a look at my use of PriorityQueue in this question? stackoverflow.com/questions/28800287/…

Collectives™ on Stack Overflow

Java PriorityQueue Comparator - How/When do you sort?

2 Answers 2

3 Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related