Class not reading constructor attribute

Question

import java.awt.Color;
import java.awt.Graphics;
import java.awt.Color;
import javax.swing.JPanel;
import java.util.Scanner;

public class BarGraph extends JPanel
{
  private int n1, n2, n3, n4, n5;
    BarGraph(int num1, int num2, int num3, int num4, int num5)
    {
        int n1 = num1;
        int n2 = num2;
        int n3 = num3;
        int n4 = num4;
        int n5 = num5;
    }

    public void paintComponent( Graphics g )
    {
        super.paintComponent(g);
        g.drawRect(0, 100, 100, 10);
        g.drawRect(0, 0, n1 * 10, 10);
        g.drawRect(0,20, n2 * 10, 10);
        g.drawRect(0,40, n3 * 10, 10);
        g.drawRect(0,60, n4 * 10, 10);
        g.drawRect(0,80, n5 * 10, 10);
     System.out.print(n1);
    }
}

BarGraphTest

package BarGraph;

import javax.swing.JFrame;
import javax.swing.JOptionPane;
import java.util.Scanner;
/*
 * To change this license header, choose License Headers in Project Properties.
 * To change this template file, choose Tools | Templates
 * and open the template in the editor.
 */

/**
 *
 * @author AJ
 */
public class BarGraphTest
{
    public static void main( String[] args)
    {

                System.out.print("Enter 5 integers seperated by spaces:");
                Scanner input = new Scanner(System.in);
                int n1 = input.nextInt();
                int n2 = input.nextInt();
                int n3 = input.nextInt();
                int n4 = input.nextInt();
                int n5 = input.nextInt();

        BarGraph panel = new BarGraph(n1, n2, n3, n4, n5);
        JFrame application = new JFrame();
        application.setDefaultCloseOperation( JFrame.EXIT_ON_CLOSE );
        application.add( panel );
        application.setSize( 300, 300);
        application.setVisible( true );
    }
}

Basically trying to get 5 integers and draw 5 rectangles that are scaled accordingly. My variables are empty though. Am I missing something? I System.out.printed the variable n1, but there is nothing in it.

What is a variable declaration? How do you do it? Once you've answered that, what are you doing here: int n1 = num1;? — Sotirios Delimanolis
– Sotirios Delimanolis, Commented Apr 1, 2014 at 19:16

rgettman · Accepted Answer · 2014-04-01 19:16:54Z

2

In your constructor for BarGraph, you've declared local variables and ignored your class variables, so the class variables don't get assigned. Local variables take precedence over class variables. Remove the int to remove the declaration, and the class variables will get resolved properly.

Change

BarGraph(int num1, int num2, int num3, int num4, int num5)
{
    int n1 = num1;
    int n2 = num2;
    int n3 = num3;
    int n4 = num4;
    int n5 = num5;
}

to

BarGraph(int num1, int num2, int num3, int num4, int num5)
{
    n1 = num1;
    n2 = num2;
    n3 = num3;
    n4 = num4;
    n5 = num5;
}

answered Apr 1, 2014 at 19:16

rgettman

179k30 gold badges282 silver badges365 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user3485650 Over a year ago

Thank you for taking the time out of your day to answer such a simple minded question!

Collectives™ on Stack Overflow

Class not reading constructor attribute

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related