C++ Dealing with 'struct' and Strings

Question

I have A problem in my C++ Code , I want to add 'n' number of Students with there Each Date , but I have an error when I Compare with if , here is my code

#include <iostream>
#include <stdio.h>
#include <string.h>
struct Address
{
char city[20];
char street[20];    
};
struct University
{
char name1[20],name2[20],name3[20]; 
};
struct student 
{   
char name[20];
char degree[20];
University un;
Address add;
};

using namespace std;
int main (){

    student st[20];
    int n,i,j;
    do{cin>>n;}while(n<=0 || n>20);

    for(i=0;i<n;i++)
    {
        cout<<" Name Of student  "<<i+1<<"\n";
        cin>>st[i].name;

        cout<<" Degree Of student  "<<i+1<<"\n";
        cin>>st[i].degree;

        cout<<"   University 1 \n";
        cin>>st[i].un.name1;
        cout<<"   University 2 \n";
        cin>>st[i].un.name2;
        cout<<"   University 3 \n";
        cin>>st[i].un.name3;

        cout<<" Enter The City Of student  "<<i+1<<"\n";
        cin>>st[i].add.city;

        cout<<" Enter The Street Of student  "<<i+1<<"\n";
        cin>>st[i].add.street;

        cout<<"\n* * * * * * * * * * * * * * * * * * * *\n";

    }   

    for(i=0;i<n;i++)
        if(st[i].degree == "phD")
        cout<<st[i].name<<"  is  OK";

    cout<<endl;
    return 0;
}

So , I want To Check if the Student Has "phD" Then Output his name , But I get An Error , there is not output after the Date inputed , Why ? And When I change the date type of "degree" to string then I get Another Error in the if Say (is not a member of 'student').But I Really Want to do it With char , Can Help me please ?

Brian Cain · Accepted Answer · 2014-04-03 17:52:25Z

1

For members like char city[20];, you should instead consider the std::string type. It provides the equality operator that you use in your comparison (==) and several other features.

answered Apr 3, 2014 at 17:52

Brian Cain

14.6k3 gold badges53 silver badges89 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

EmptyData · Accepted Answer · 2014-04-03 17:54:19Z

0

use strcmp (http://en.cppreference.com/w/c/string/byte/strcmp) to compare char strings

like:

for(i=0;i<n;i++)
        if(strcmp(st[i].degree,"phD") == 0)
        cout<<st[i].name<<"  is  OK";

or

IF you wanna use string in struct you can change your code like this :

struct student 
{   
char name[20];
string degree;
University un;
Address add;
};

then your for loop will remain same

edited Apr 3, 2014 at 17:54

answered Apr 3, 2014 at 17:47

EmptyData

2,6064 gold badges29 silver badges44 bronze badges

5 Comments

user3457718 Over a year ago

thanks , but should I use A Function?Imean Not Done Without function

Deduplicator Over a year ago

0-terminated char strings please.

Deduplicator Over a year ago

Unless you have specific reason to reinvent the wheel (aka school): Yes, use standard functions.

EmptyData Over a year ago

@user3457718 this is a standard function in string.h please refer en.cppreference.com/w/c/string/byte/strcmp

EmptyData Over a year ago

@user3457718 if you want to use string in struct I edited my answer above

Collectives™ on Stack Overflow

C++ Dealing with 'struct' and Strings

2 Answers 2

Comments

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related