Java, Objects, Constructors: Getting a NullPointerException error

Question

Here's the error I'm getting:
I know it's telling me that a[0].setAttribute(0); is wrong, but I don't know why it's wrong. How should I be filling up the Instance array with values?

java.lang.NullPointerException
    at DecisionTree.TestTree.main(TestTree.java:6)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
    at java.lang.reflect.Method.invoke(Unknown Source)
    at edu.rice.cs.drjava.model.compiler.JavacCompiler.runCommand(JavacCompiler.java:272)

This is the class I'm using to test my constructors.

package DecisionTree;

public class TestTree {
  public static void main(String[] args) {
    Instance[] a = new Instance[5];
    a[0].setAttribute(0);
    a[1].setAttribute(1);
    a[2].setAttribute(2);
    a[3].setAttribute(3);
    a[4].setAttribute(4);
    a[0].setLabel(true);
    a[1].setLabel(false);
    a[2].setLabel(true);
    a[3].setLabel(false);
    a[4].setLabel(true);
    DecisionTree work = new DecisionTree(a);
    System.out.println(work.root.cutoff);
  }
}

The instance class:

package DecisionTree;

public class Instance {

    double attribute;
    boolean label;

    public Instance(double a, boolean c) {
 attribute = a;
 label  = c;
    }

    public double getAttribute() {
 return attribute;
    }

    public void setAttribute(double a) {
 attribute = a;
    }

    public boolean getLabel() {
 return label;
    }

    public void setLabel(boolean c) {
 label = c;
    }
}

There is nothing (other than a null) in a[0], since you didn't put anything there. — Hot Licks
– Hot Licks, Commented Apr 4, 2014 at 1:18

Hovercraft Full Of Eels · Accepted Answer · 2014-04-04 01:10:15Z

3

You're creating an array of reference type, of objects, but are trying to use it before filling it with valid objects. When created it's filled with nothing but nulls. So fill it, and then use it.

e.g.,

Instance[] a = new Instance[5];
for (int i == 0; i < a.length; i++) {
   // first create your instance
   a[i] = new Instance(); // don't know if this is a valid constructor

   // and only *then* can you use it
   a[i].setAttribute(i);
   a[i].setLabel(i % 2 == 0);
}

Consider an array of references like an empty parking lot. You can't drive any cars in the lot until you first put cars into the lot. Similarly, you can't use any if the items in a reference array until you first initialize those items.

answered Apr 4, 2014 at 1:10

Hovercraft Full Of Eels

286k25 gold badges268 silver badges391 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user3251142 Over a year ago

That makes sense. And so can I do a[i] = new Instance(i, i%2==0);

Hovercraft Full Of Eels Over a year ago

@user3251142: yep, if Instance has that constructor, for sure I'd use it.

user3487792 · Accepted Answer · 2014-04-04 01:14:35Z

2

You have not yet put any objects in your array. Instance[] a = new Instance[5];

//creates an empty array of size 5, with space enough in each for one pbject of type instance. So you now have to put 5 Instances in there.

Instance a1 = new Instance();
a[0] = a1;
Instance a2 = new Instance();
..
Instance a5 = new Instance();

or,

for(int i =0; i <5; i++){
a[i] = new Instance;
}

or some variation of this.

answered Apr 4, 2014 at 1:14

user3487792

355 bronze badges

Comments

luizcarlosfx · Accepted Answer · 2014-04-04 01:14:44Z

1

When you declare an array of objects all elements inside it will be by default null. You need to create Instance instances and insert into it on the array before use the array elements

answered Apr 4, 2014 at 1:14

luizcarlosfx

4091 gold badge4 silver badges11 bronze badges

Collectives™ on Stack Overflow

Java, Objects, Constructors: Getting a NullPointerException error

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related