PHP: Error handling without throwing an exception

Question

I'm sending multiple emails from a PHP application, and I want to inform the user of the emails that failed to be sent.

What is the most elegant way to do the error handling when

I don't want to throw an exception that terminates the sending of the remaining emails
The call goes through several method calls

What I want is to get the $notificationSucceeded back from Suggestion::notifyDeletionToAll() to SuggestionController somehow nicely from all notifications.

The depth of the call stack made me doubt if returning it through all the methods is the most elegant way, especially when I already have a return value from Suggestion::cancel().

Is there a better way?

Controller:

class SuggestionController {
    function cancelSuggestion($suggestionId)
    {
        $suggestion = new Suggestion();
        $suggestion->fetch($suggestionId);

        $suggestionDeleted = $suggestion->cancel();

        print json_encode(array(
            'status' => 'ok',
            'suggestionDeleted' => $suggestionDeleted,
        ));
    }
}

Suggestion class:

class Suggestion {

    /**
     * Cancels membership of current user in the suggestion
     */
    public function cancel()
    {
        $this->cancelMembership();

        if (!$this->hasAcceptedMembers()) {
            $this->deleteAndNotify();
            return true;
        }

        return false;
    }

    /**
     * Deletes the suggestion and notifies all the users in it
     */
    private function deleteAndNotify()
    {
        $this->notifyDeletionToAll();
        DB::inst()->query("DELETE FROM suggestions WHERE id = {$this->id}");
    }

    /**
     * Notifies about the deletion of the suggestion to all members (users in the suggestion)
     */
    private function notifyDeletionToAll()
    {
        $result = DB::inst()->query("SELECT user_id FROM suggestions_users
            WHERE suggestion_id = {$this->id}");
        while ($member_id = DB::inst()->fetchFirstField($result)) {
            $member = new User();
            $member->fetch($member_id);
            $notificationSucceeded = $member->notifySuggestionDeleted($this);
        }
    }
}

Your question isn't clear. Add more details: your important code snippets, description of desired behavior e t.c. — Alma Do
– Alma Do, Commented Apr 7, 2014 at 6:03
Since you said "The call goes through several method calls", how about using return value of the method and everytime "false" is returned, add a line with something like "Email #1 was unable to send" into variable? — FanaticD
– FanaticD, Commented Apr 7, 2014 at 6:05

Dinesh Babu · Accepted Answer · 2014-04-07 06:25:31Z

1

I can't understand your question clearly. but i hope this will help you

$successfully_sent_arr = array();
$failure_notsent_arr   = array();
if($mail->Send())
{
    $successfully_sent_arr[] = $to_email;
    //Once the last loop occurs, update this array in database
}
else
{
    $failure_notsent_arr[] = $to_email;
    //Once the last loop occurs, update this array in database
}

answered Apr 7, 2014 at 6:25

Dinesh Babu

4564 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Ipa Over a year ago

I clarified the question.

Dinesh Babu Over a year ago

@Ipa Ok will check and come back

Collectives™ on Stack Overflow

PHP: Error handling without throwing an exception

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related