Java while loop never enters loop

Question

I'm writing a video poker in java, and I need to ask the player if the want to remove any cards from their hand. I wrote a while loop for that, but it is not working the way it's supposed to right now. I'd appreciate if someone could send me in the right direction--I'm still new to java.. Thanks. (the counter is there so that the player doesn't remove more than 5 cards)

    String response = "y";
    int counter = 0;
    System.out.println("Remove any cards?");
    System.out.println("Enter y for 'yes' and n for 'no'");
    response = input.nextLine();
    while((response != "n") && (counter < 5))
    {

        System.out.println("Enter the number of a card to be removed (1-5)");
        int l = input.nextInt();
        p.removeCard(p.getHand().get(l-1));
        p.addCard(cards.deal());
        cards.incrementTop();
        counter ++;
        System.out.println("Card removed. More? Type 'yes' or 'no'");
        String answer = input.nextLine();
        if (answer == "no")
            {
                response = "n";
            }       
    }

What way is it working right now, and how does it differ from how it's "supposed" to work? — Mark Peters
– Mark Peters, Commented Apr 7, 2014 at 16:04

Marco Acierno · Accepted Answer · 2014-04-07 16:09:41Z

5

You can't compare Strings using != or ==.

Use .equals()

while(!("n".equals(response)) && (counter < 5))

The same here too

if (answer == "no")

Other things to improve

The user could write "no" the first time and how it's done right now it could not work
- You ask to the user to write "no" but you check for "n"
What about N? Y?
What about nO? NO? (Hint: search .equalsIgnoreCase())

Another hint for you: Use a boolean variable for yes/no, is better and more easy :)

edited Apr 7, 2014 at 16:09

answered Apr 7, 2014 at 16:04

Marco Acierno

14.9k8 gold badges45 silver badges53 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user3505003 Over a year ago

Thanks! I always forget that about strings. But I don't understand why after asking if the player wants to remove more cards it doesn't wait for the answer and goes straight to the 1st line of the loop again. Why does this happen?

Benjamin · Accepted Answer · 2014-04-07 16:09:19Z

2

Try using the String.equals() method to compare strings. Your while loop should be

 while(( !response.equals( "n" )) && (counter < 5))
  {
       //do Something 
  }

edited Apr 7, 2014 at 16:09

Benjamin

2,3061 gold badge17 silver badges24 bronze badges

answered Apr 7, 2014 at 16:07

Anthony_Michael

424 bronze badges

Collectives™ on Stack Overflow

Java while loop never enters loop

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related