how to insert a loop in a String toString() method in java

Question

I am looking to pass a long list of results in a String toString() method,this is my code

public void newlist(){
    for(int i = 0 ; i <= nbComposant;i++){
        System.out.print(ref+i+" (quantity  "+quantity+i+")");
    }
}

public String toString(){
    return newlist();
}

What's wrong with it?

the return type of your newlist() method is void. Should be String. — donfuxx
– donfuxx, Commented Apr 7, 2014 at 20:52
Why is newList separate method? Also why does it not return anything (its return type is void)? — Pshemo
– Pshemo, Commented Apr 7, 2014 at 20:52
Are ref and quantity arrays? Do you intend to print each element of these arrays on separate lines? — Dawood ibn Kareem
– Dawood ibn Kareem, Commented Apr 7, 2014 at 21:02

Mani · Accepted Answer · 2014-04-07 21:04:28Z

3

public String toString(){
        StringBuilder builder = new StringBuilder(256); 
        for(int i = 0 ; i <= nbComposant;i++){
            builder.append(ref).append(i).append(" (quantity  ").append((quantity+i)).append(")");
        }
        return builder.toString();
}

You dont need Separate method for this. Use Stringbuilder instead of "+" . Though Recent JVM converts into Stringbuilder it would be good practice to write it.

I dont know what is your excepted Result String. I just copied from your question.

edited Apr 7, 2014 at 21:04

answered Apr 7, 2014 at 20:59

Mani

3,3642 gold badges19 silver badges27 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

T McKeown · Accepted Answer · 2014-04-07 20:53:53Z

1

public String newlist(){
  StringBuilder sb = new StringBuilder();
    for(int i = 0 ; i <= nbComposant;i++){
        sb.append(ref+i+" (quantity  "+quantity+i+")");
    }
   return sb.toString();
}
public String toString(){
    return newlist();
}

answered Apr 7, 2014 at 20:53

T McKeown

12.9k1 gold badge27 silver badges35 bronze badges

5 Comments

Franz Ebner Over a year ago

what about a line break?

Franz Ebner Over a year ago

Do you try to iterate an array with +quantity+i+.

Dawood ibn Kareem Over a year ago

I doubt whether this actually does exactly what NadNet wants. What would be the point of repeating ref and quantity? Most likely, these are actually arrays which NadNet wants to iterate through.

T McKeown Over a year ago

his question was how to get a value from his list in the .toString(). i'm not a mind reader.

Dawood ibn Kareem Over a year ago

Yes, you're not a mind reader. And that's why Stack Overflow makes it possible to comment on questions - so that we can seek clarification when the question is unclear, before jumping in and answering it. The question does say "I am looking to pass a long list of results" - which should be enough of a hint that this approach is not going to do what the OP needs.

Collectives™ on Stack Overflow

how to insert a loop in a String toString() method in java

2 Answers 2

Comments

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related