Save jQuery selector and function to variable

Question

I have a Save/Edit button. I would like it to do different things depending on whether it's currently a Save button or an Edit button. For clarity, I want to save the jQuery selector and function to a variable name, then call it:

    $('div#' + id + ' .edit').click(function(){

        var i = this;
        var state = function(st){
            if( typeof st !== 'undefined')
                $(i).html(st);
            else
                return $(i).html();
        };

        if( state() == 'Edit' ) {
            controller.edit(id);
            state('Save');
        } else {
            controller.save();
            state('Edit');
        }

    });

My question: is there a faster way to do this? Something like the following:

    $('div#' + id + ' .edit').click(function(){

        var state = $(this).html;

        if( state() == 'Edit' ) {
            controller.edit(id);
            state('Save');
        } else {
            controller.save();
            state('Edit');
        }

    });

...but this does not work.

This example is just an example; I know there are many ways to do what it's trying to do without saving the selector and the function to a variable. Nonetheless, the question still stands: is it possible to do this faster?

adeneo · Accepted Answer · 2014-04-08 02:01:33Z

3

Why not just

$('#' + id + ' .edit').on('click', function(){
    $(this).text(function(_, txt) {
        if (txt == 'Edit') {
            controller.edit(id);
            return 'Save';
        } else if (txt == 'Save') {
            controller.save();
            return 'Edit';
        }
    });
});

edited Apr 8, 2014 at 2:01

answered Apr 8, 2014 at 1:35

adeneo

319k29 gold badges410 silver badges392 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

sg.cc Over a year ago

Your particular example doesn't change the text of the button after it's been clicked. And as I'd mentioned, I know there are different ways of doing it without saving the selector and function. I want to know whether saving selector and function is at all possible.

adeneo Over a year ago

@sg.cc - It's not really clear what you're trying to do, as the code you've posted doesn't really make any sense, but I edited the answer to change the button text as well ?

zzzzBov Over a year ago

$(this).text(_, txt) { doesn't make sense. I assume you meant to write $(this).text(function (_, txt) {

Roko C. Buljan · Accepted Answer · 2014-04-08 02:27:38Z

0

jQuery elements are objects so why not store directly into your Object element the desired state:

DEMO

$('div#' + id + ' .edit').click(function(){
  var es = this.es ^= 1;           // Toggle/Store state
  $(this).text(es?'Save':'Edit');
  return controller[es?'edit':'save'](id);
});

edited Apr 8, 2014 at 2:27

answered Apr 8, 2014 at 2:22

Roko C. Buljan

209k41 gold badges335 silver badges346 bronze badges

Collectives™ on Stack Overflow

Save jQuery selector and function to variable

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related