Jquery .on('click,'button' not working

Question

I need to check if user closed browser. There is no reliable way, but the most accurate way seems to use onbeforeunload and check if a link or a button was clicked. I will also add f5 and some other extra checking.

But I have problem with button. If I click button, ajax call will be made even if there is if(window.link_was_clicked==false) condition.

<button onclick="setLocation('http://dev.site.com/checkout/')" class="button" title="Checkout" type="button"><span><span>Checkout</span></span></button>

And script:

jQuery(document).on('click', 'button', function(event) {
  window.link_was_clicked= true;
});  

window.onbeforeunload = function() {
  if(window.link_was_clicked==false){                
    //make ajax call      
  }
};

It seems the problem is because there is setLocation function attached to button onclick. Is there any way to trigger jQuery(document).on first?

which button are you talking about? are you talking about the browser close button? — Sushil
– Sushil, Commented Apr 10, 2014 at 12:26
Where is your HTML? If you aren't using a <button> tag then your jQuery won't select anything. — Tricky12
– Tricky12, Commented Apr 10, 2014 at 12:28
@Sushil I am talking about <button> html tag. I put now this into question. — JohnyFree
– JohnyFree, Commented Apr 10, 2014 at 12:35

Bellash · Accepted Answer · 2014-04-10 12:37:27Z

0

That variable doesnt exist on before load. so add it on the top and try again

     window.link_was_clicked=window.link_was_clicked||false;
     jQuery(document).on('click', 'button', function(event) {
         window.link_was_clicked= true;
      });  

     window.onbeforeunload = function() {
         if(window.link_was_clicked==false){                
        //make ajax call      
     }
    };

answered Apr 10, 2014 at 12:37

Bellash

8,2776 gold badges57 silver badges95 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

JohnyFree Over a year ago

In real code it is window.link_was_clicked= false;, I just wanted to keep example short and easy. So this is not the problem.

Community · Accepted Answer · 2017-05-23 12:13:14Z

0

Since you haven't provided the code for setLocation(), I'll assume that that's where the problem is. Now, regarding a change to the order of execution of your click event handlers:

It is in general bad to have both embedded onclick and jquery-bound handlers, it leads to all sorts of confusion. If you can't change the html, however, you could do what this guy suggests: https://stackoverflow.com/a/7507888/2685386

$(document).ready(function() {
    var myClick = $('button').attr('onclick');
    $('button').removeAttr('onclick');

    $(document).on('click', 'button', function(e) {
        window.link_was_clicked=true;
        // do my other stuff here....
        eval(myClick);// this will now call setLocation()
    });
});

edited May 23, 2017 at 12:13

CommunityBot

11 silver badge

answered Apr 10, 2014 at 13:29

blgt

8,2151 gold badge27 silver badges29 bronze badges

Collectives™ on Stack Overflow

Jquery .on('click,'button' not working

2 Answers 2

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related