Java script adding option values

Question

Im trying to add selected option but it doesnt seem to work.I want to be able to add selected options and display them in a text box with id = tot. At the moment it does view the value in the text box but it does not add it just views the value of the option i have selected.

<script type="text/javascript">

 function check_sm() {
        var value1 = 0;
        var sm1 = document.getElementById("slides");
        for (var i = 0; i < sm1.length; i++) {
            if (sm1[i].selected)
            { value1 = (eval(value1) + eval(sm1[i].value)); }
        } document.getElementById("SCregistration").tot.value = value1;

    }

</script>





<body>
<form>
Do you want a copy of the short course details?
<select id="slides" onChange="check_sm()">
    <option value="50">Yes</option>
    <option value="20">No</option>
</select>

</body>
</form>

What the heck are you using eval() here for? It has no place here whatsoever. value1 += parseInt(sm1.value, 10);. — gen_Eric
– gen_Eric, Commented Apr 10, 2014 at 14:40
Also, getElementById only returns one element, not a list of elements. — gen_Eric
– gen_Eric, Commented Apr 10, 2014 at 14:41
In the first line of your function , isn't var value1 = 0; supposed to be var value1 = document.getElementById("SCregistration").tot.value ? — Batu.Khan
– Batu.Khan, Commented Apr 10, 2014 at 14:43

Barmar · Accepted Answer · 2014-04-10 15:21:19Z

1

function check_sm() {
    var slides = document.getElementById("slides");
    var selected = slides.selectedIndex;
    var optValue = parseInt(slides.options[selected].value, 10);
    var oldTot = parseInt(document.getElementById('SCregistration').tot.value, 10);
    document.getElementById('SCregistration').tot.value = oldTot + optValue;
}

DEMO

edited Apr 10, 2014 at 15:21

answered Apr 10, 2014 at 14:47

Barmar

789k57 gold badges554 silver badges669 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

user3519941 Over a year ago

It doesnt seem like its working ... is there anything i should know?

Barmar Over a year ago

I fixed several typos. Also, it should be slides.options, not slides.childNodes.

user3519941 Over a year ago

I checked out your demo and it works however its not working in my script i dont get whats wron... grrrr so frustrating!

Collectives™ on Stack Overflow

Java script adding option values

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related