SQL syntax error - insert into statement

Question

Good afternoon all. I've been getting the following error when running the following INSERT INTO statement.

Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ' , , , , , , , , , )' at line 2

I'm totally stumped. Could this be anything to do with the incremental value I have in my table called 'id'?? Here's the code. Many thanks in advance!!

<?php
$con=mysqli_connect("localhost","root","root","wexdemo");

if (mysqli_connect_errno())
{
  echo "Failed to connect to MySQL: " . mysqli_connect_error();
}


$name = mysqli_real_escape_string($_POST['name']);
$address = mysqli_real_escape_string($_POST['address']);
$area = mysqli_real_escape_string($_POST['area']);
$postcode = mysqli_real_escape_string($_POST['postcode']);
$sector = mysqli_real_escape_string($_POST['sector']);
$subsector = mysqli_real_escape_string($_POST['subsector']);
$contact = mysqli_real_escape_string($_POST['contact']);
$position = mysqli_real_escape_string($_POST['position']);
$email = mysqli_real_escape_string($_POST['email']);
$telephone = mysqli_real_escape_string($_POST['telephone']);

$sql="INSERT INTO employers (name, address, area, postcode, sector, subsector, contact, position, email, telephone)
VALUES ($name, $address, $area, $postcode, $sector, $subsector, $contact, $position, $email, $telephone)";

if (!mysqli_query($con,$sql))
{
  die('Error: ' . mysqli_error($con));
}
echo "1 record added";

mysqli_close($con);
?>

always try to debug your code,you can simply print your query and check what is the actual query that is executing — ɹɐqʞɐ zoɹǝɟ
– ɹɐqʞɐ zoɹǝɟ, Commented Apr 11, 2014 at 14:57
@PhilHowell: It would be best, if working with mysqli_prepare — Ravinder Reddy
– Ravinder Reddy, Commented Apr 11, 2014 at 15:19

Krish R · Accepted Answer · 2014-04-11 14:55:16Z

3

Insert query values should be wrapped inside the ' single quote or "double quotes.

$sql ="INSERT INTO employers (`name`, `address`, `area`, `postcode`, `sector`, `subsector`, `contact`, `position`, `email`, `telephone`)
 VALUES ('$name', '$address', '$area', '$postcode', '$sector', '$subsector',
       ..^
 '$contact', '$position', '$email', '$telephone')";

instead of

$sql="INSERT INTO employers (name, address, area, postcode, sector, subsector, contact, position, email, telephone)
VALUES ($name, $address, $area, $postcode, $sector, $subsector, $contact, $position, $email, $telephone)";

answered Apr 11, 2014 at 14:55

Krish R

22.7k7 gold badges54 silver badges60 bronze badges

Sign up to request clarification or add additional context in comments.

12 Comments

Phil Howell Over a year ago

Hi Krish, I added the single quotes which took away the error message but the data is not being inserted correctly into the table. The auto incremental "id" column is the only data that appears on each row...

Krish R Over a year ago

Can you post your table structure?

Ravinder Reddy Over a year ago

@PhilHowell: Before calling mysqli_query, debug with echo $sql;. That lets you know if proper data is being sent to database.

Phil Howell Over a year ago

@KrishR I'm not sure how to do that. Could you kindly advise?

Krish R Over a year ago

Please make sure you run this code only after the form submit, since you have used POST of values.

|

NorthBridge · Accepted Answer · 2014-04-11 14:56:59Z

1

The values you're inserting need to be in single or double quotes, if their column type is string. Try this code:

$sql="INSERT INTO employers (name, address, area, postcode, sector, subsector, contact, position, email, telephone)
VALUES ('$name', '$address', '$area', '$postcode', '$sector', '$subsector', '$contact', '$position', '$email', '$telephone')";

The only values you probably don't want enclosed in quotes are those who have numeric values - i.e. probably $postcode and $telephone

answered Apr 11, 2014 at 14:56

NorthBridge

6748 silver badges20 bronze badges

Comments

stefano5010 · Accepted Answer · 2021-07-16 10:14:32Z

0

Variables should not be included in 'or "; I get the same error even though the query is populated and and looks right MyError: INSERT INTO dati_modelle VALUES (1, sonia, nota 1, 14, Height, 165, Bust, 60, Waist, 65, Hips, 60, Shoe, 33, Eyes, brown) You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '1, 14, Height, 165, Bust, 60, Waist, 65, Hips, 60, Shoe, 33, Eyes, brown)' at line 1

answered Jul 16, 2021 at 10:14

stefano5010

12 bronze badges

Comments

Siva Koteswara Rao · Accepted Answer · 2021-07-16 10:29:44Z

-1

$sql="INSERT INTO employers (name, address, area, postcode, sector, subsector, contact, position, email, telephone) VALUES ( " + "" + $name +"" + ", " + "" + $address +"" + ", " + "" + $area + "" + ", " + ""+ $sector + "" + ", " + ""+ $subsector+ "" + ", " + ""+$contact + "" + ", " + ""+$position +"" + ", " + ""+ $email + "" + ", " + ""+ $telephone + "" + ")";

answered Jul 16, 2021 at 10:29

Siva Koteswara Rao

1311 silver badge6 bronze badges

1 Comment

Nico Haase Over a year ago

If that should be PHP code: please never recommend the usage of such highly insecure code

Collectives™ on Stack Overflow

SQL syntax error - insert into statement

4 Answers 4

12 Comments

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

12 Comments

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related