inserting double number into access database c#

Question

i use this query to insert data

cmd = new OleDbCommand("insert into avoir_note  values ('" + 
       comboBoxA.Text + "','" + comboBoxCM.Text + "','" + 
       comboBoxCE.Text + "','" + textBoxMat.Text + "'," +
       Convert.ToDouble(textBoxNote.Text)+ ",'" + 
       dateTimePickerDT.Text + "') ", Program.cn)

if i type for exemple 10 in textBoxNote it s work but

if i type for exemple 10,15 in textBoxNote i get this error The number of query values must match the number of fields destination. if i type for exemple 10.15 in textBoxNote i get this error input string was not in correct format

Please use parameterized queries. This kind of string concatenations are open for SQL Injection attacks. — Soner Gönül
– Soner Gönül, Commented Apr 11, 2014 at 21:20

Guffa · Accepted Answer · 2014-04-11 21:22:12Z

2

FIrst of all, you shouldn't concatenate the values into the query like that, you should use a parameterised query. Then you don't have those problems with formatting the values correctly.

The reason for the error message is that you are formatting the floating point number with a comma as decimal separator, but the database expects it to be a period. The comma makes it two separate values instead of one, so the number of values doesn't match the number of fields. Use a culture information that has a period as decimal separator to format the number:

Convert.ToDouble(textBoxNote.Text).ToString(CultureInfo.InvariantCulture)

That will make the code work for now, so that you can make the query parameterised in your own time. The code is wide open for SQL injection attacks, so you should definitely not release it to production in its current state.

answered Apr 11, 2014 at 21:22

Guffa

703k111 gold badges760 silver badges1k bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user3416567 Over a year ago

thanks i am new in c# a don't know how to use culture information

AmmarCSE · Accepted Answer · 2014-04-11 21:21:50Z

0

Correct me if Im wrong, but that is 10,15 with a comma! You need to use a dot symbol '.'.

The error message means that the it expects a different number of parameters than the ones provided and the comma will add an extra parameter!

answered Apr 11, 2014 at 21:21

AmmarCSE

30.7k6 gold badges48 silver badges53 bronze badges

Collectives™ on Stack Overflow

inserting double number into access database c#

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related