JavaScript - Changing div's onclick with a variable?

Question

I've got a quick question: I've got a function that stores id's in an array called "view1". When a certain requirement is met, I want these id's onclick to change. I want them to load a function called clickMem(id) when they are clicked, and also send in their id in the function. So I've tried this with the first id in the array and it didn't work, what am I doing wrong?

document.getElementById(view1[0]).onclick='clickMem('+view1[0]+');';

Thank you in advance!

onclick expects a function, not a string. See developer.mozilla.org/en-US/docs/Web/API/… — Felix Kling
– Felix Kling, Commented Apr 12, 2014 at 17:17
Setting the onclick event will do nothing but bind a function to the event. The event needs to be triggered for something to happen. From reading your question, it sounds like you want the function to run when the condition is met, not just bind the function and do nothing. Am I right? — Eli Sand
– Eli Sand, Commented Apr 12, 2014 at 17:27
Oh, no, I just want to bind the function to the id. I don't want it to run until the div with the id is clicked. And I'm afraid the answers below doesn't seem to work for me... — user3527311
– user3527311, Commented Apr 12, 2014 at 21:41

Aditya · Accepted Answer · 2014-04-12 21:59:01Z

1

Use setAttribute :

  var new_onclick = 'clickMem('+view1[0]+')';
  document.getElementById(view1[0]).setAttribute('onclick',new_onclick);

But Note:

document.getElementById('buttonLED'+id).onclick = clickMem(view1[0]);

Sets the onclick property of the element to the result of clickMem(view1[0]) as it would call that function and assign the value returned by that function to the onclick property, which is something you don't want.

So pass a function(){clickMem(view1[0]);}

document.getElementById('buttonLED'+id).onclick = function(){clickMem(view1[0]);}

which can also work .

edited Apr 12, 2014 at 21:59

answered Apr 12, 2014 at 17:17

Aditya

4,4733 gold badges30 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

vivek_nk Over a year ago

why not document.getElementById(view1[0]).onclick=clickMem(view1[0]);?

Felix Kling Over a year ago

@vivek_nk: That would execute clickMem immediately, not when the click event is triggered.

Felix Kling Over a year ago

@Aditya: The result your .onclick solution is different from your setAttribute solution.

Aditya Over a year ago

Yes i meant BUT not OR, updated answer and thanks a ton for pointing out there

Felix Kling Over a year ago

I don't think "BUT" makes it clear enough what the difference is. Instead of writing a comment, I'd suggest to properly write two or three sentences about the differences, and really make clear that those are two different solutions. Why are suggestion two different solutions anyway?

|

vivek_nk · Accepted Answer · 2014-04-12 17:45:13Z

0

Try this:

document.getElementById(view1[0]).onclick=function() {clickMem(view1[0]);}

edited Apr 12, 2014 at 17:45

answered Apr 12, 2014 at 17:19

vivek_nk

1,60016 silver badges27 bronze badges

1 Comment

Felix Kling Over a year ago

You are assuming that clickMem returns a function, which it might not do.

Collectives™ on Stack Overflow

JavaScript - Changing div's onclick with a variable?

2 Answers 2

8 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

8 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related